Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pump Up to the list of stims in Haloperidol and Nanocalcium #28444

Merged

Conversation

WenlockTheBritishHobo
Copy link
Contributor

What Does This PR Do

Adds Pump Up to the list of stimulants that Haloperidol purges and the list of stimulants that nanocalcium checks for.

Why It's Good For The Game

Fixing oversights is a good thing.

Testing

Put 50u of Pump Up in a human, shot at the human with a tranquiliser dart shell, saw Pump Up being removed as Haloperidol normally does for stimulants.

Put 40u of Pump Up in a Drask, used a nanocalcium injector, once the generous purging phase ended toxin damage as expected for stimulants began to occur, this caused the death of the Drask.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Fixed the oversight of Pump Up not being purged by Haloperidol.
fix: Fixed the oversight of Pump Up not being among the stimulants that Nanocalcium checks for.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 18, 2025
@Spaghetti-bit Spaghetti-bit added the Fix This PR will fix an issue in the game label Feb 19, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Feb 19, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 20, 2025
@lewcc lewcc added this pull request to the merge queue Feb 24, 2025
@lewcc lewcc added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Feb 24, 2025
Merged via the queue into ParadiseSS13:master with commit 6b45c63 Feb 24, 2025
19 checks passed
@WenlockTheBritishHobo WenlockTheBritishHobo deleted the Halo_Stim_List_Pump_Up branch February 24, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game Requires Wiki Update Useful for Wiki Contributers to search for things that need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants