Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report - complete_forceatlas2test - overlap_method #6

Closed
ghaithcode opened this issue Mar 13, 2019 · 2 comments
Closed

Bug report - complete_forceatlas2test - overlap_method #6

ghaithcode opened this issue Mar 13, 2019 · 2 comments

Comments

@ghaithcode
Copy link

Hello,

I noticed that the complete_forceatlas2 function does not accept overlap.method ="expand". I debugged the issue and I found out that there is a small typo in the if statement in the complete_forceatlas2 as follows:

This condition:

else if(overlap_method == "expand")
G <- adaptive_expand(G, overlap.iter)

need to be modified to:

else if(overlap.method == "expand")
G <- adaptive_expand(G, overlap.iter)

Thanks,

Ghaith,

@ghaithcode ghaithcode changed the title Bu report - complete_forceatlas2test - overlap_method Bug report - complete_forceatlas2test - overlap_method Mar 13, 2019
@pfgherardini
Copy link
Contributor

You are right! Thank you very much for reporting and providing a fix.

Federico

@ghaithcode
Copy link
Author

ghaithcode commented Mar 13, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants