Allow customization of native outgoing messages #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SzymonPobiega
requested review from
ramonsmits,
WilliamBZA,
tmasternak and
irinascurtu
irinascurtu
approved these changes
Oct 14, 2024
tmasternak
approved these changes
Oct 14, 2024
irinascurtu
approved these changes
Oct 14, 2024
src/NServiceBus.Transport.RabbitMQ.Tests/ApprovalFiles/APIApprovals.Approve.approved.txt
Outdated
Show resolved
Hide resolved
src/NServiceBus.Transport.RabbitMQ.Tests/ApprovalFiles/APIApprovals.Approve.approved.txt
Outdated
Show resolved
Hide resolved
src/NServiceBus.Transport.RabbitMQ/Sending/BasicPropertiesExtensions.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Transport.RabbitMQ/Sending/BasicPropertiesExtensions.cs
Outdated
Show resolved
Hide resolved
SzymonPobiega
force-pushed
the
set-native-content-type
branch
from
b3d7983 to
6297709
Compare
SzymonPobiega
changed the title
content-type AMQP attribute via DispatchProperties for the purposes of native integration directly via the transport seam
SzymonPobiega
requested review from
irinascurtu,
tmasternak and
danielmarbach
src/NServiceBus.Transport.RabbitMQ/Sending/MessageDispatcher.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Transport.RabbitMQ.TransportTests/When_customizing_outgoing_messages.cs
Outdated
Show resolved
Hide resolved
tmasternak
approved these changes
Oct 25, 2024
…header entry Co-authored-by: Daniel Marbach <[email protected]>
SzymonPobiega
force-pushed
the
set-native-content-type
branch
from
3ba3cd8 to
c4f3f9a
Compare
Co-authored-by: Daniel Marbach <[email protected]>
|
Folks, given that we were able to verify it work OK in the connector, could you re-approve so that I can merge and release it? |
WilliamBZA
approved these changes
Nov 4, 2024
danielmarbach
approved these changes
Nov 4, 2024
Co-authored-by: Daniel Marbach <[email protected]>
irinascurtu
approved these changes
Nov 4, 2024
ramonsmits
approved these changes
Nov 5, 2024
SzymonPobiega
added a commit
that referenced
this pull request
Nov 5, 2024
Allow setting customizing the outgoing messages by setting AMQP attributes just before dispatching the message to the broker
WilliamBZA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an API for registering a callback that can modify messages just before they are dispatched to the broker. It allows setting AMQP properties that can't be influenced otherwise or override NServiceBus default behavior if the receiver expects a very specific message format.