New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stylistic and more idiomatic code #45

Merged

PatrickF1 merged 1 commit into PatrickF1:main from IlanCosman:main

Oct 5, 2020

Collaborator

IlanCosman commented Oct 5, 2020 •

edited by PatrickF1

Loading

A few incredibly minor edits:

Use test instead of [ ... ], in accordance with documentation and the rest of the code. Bracket test builtin (e.g. "if [ $string ]") should be documented fish-shell/fish-shell#1850 says that use of the square brackets for test is highly discouraged.
Use 2>/dev/null instead of 2> /dev/null. This is preferred by fish_indent. I can demonstrate this if you wish.
Use string escape "$blah" instead of echo $blah | string escape


          Minor edits

fa453fa

PatrickF1 changed the title ~~Minor edits~~ Stylistic and more idiomatic code

Owner

PatrickF1 commented Oct 5, 2020

Hi again, boy how many times have you read through my code? Really appreciate my thoroughness.

PatrickF1 merged commit feb5fcd into PatrickF1:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet