Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding refactoring #1

Merged
merged 30 commits into from
May 18, 2021
Merged

Coding refactoring #1

merged 30 commits into from
May 18, 2021

Conversation

eniocc
Copy link
Collaborator

@eniocc eniocc commented Apr 21, 2021

In this request I made a lot of changes in the file DSS.py. All code were break in new classes each one with specific responsabilities. I added a folder named samples to help new enthusiasts with this beautiful and usefull module for OpenDSS.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2021

Codecov Report

Merging #1 (bcc3a1a) into master (6135830) will increase coverage by 20.30%.
The diff coverage is 53.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #1       +/-   ##
===========================================
+ Coverage   34.02%   54.33%   +20.30%     
===========================================
  Files           3      217      +214     
  Lines        3350     3764      +414     
  Branches        6       55       +49     
===========================================
+ Hits         1140     2045      +905     
+ Misses       2207     1707      -500     
- Partials        3       12        +9     
Impacted Files Coverage Δ
src/py_dss_interface/DSS.py 84.74% <ø> (+51.33%) ⬆️
...rc/py_dss_interface/models/ErrorInterface/Error.py 0.00% <0.00%> (ø)
...y_dss_interface/models/ErrorInterface/ErrorCode.py 0.00% <0.00%> (ø)
...y_dss_interface/models/ErrorInterface/ErrorDesc.py 0.00% <0.00%> (ø)
...py_dss_interface/models/ErrorInterface/__init__.py 0.00% <0.00%> (ø)
src/py_dss_interface/models/Bridge.py 24.48% <24.48%> (ø)
...y_dss_interface/models/CapControls/CapControlsF.py 28.94% <28.94%> (ø)
src/py_dss_interface/models/Base.py 32.81% <32.81%> (ø)
.../py_dss_interface/models/CktElement/CktElementS.py 37.03% <37.03%> (ø)
src/py_dss_interface/models/Monitors/MonitorsI.py 37.50% <37.50%> (ø)
... and 422 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6135830...bcc3a1a. Read the comment docs.

…ne class named Base. Another class must be implementd like ActiveClass, Bus, Capacitors, CapControls and Circuit classes
@PauloRadatz PauloRadatz merged commit f1561cd into PauloRadatz:master May 18, 2021
@eniocc eniocc deleted the refactoring branch October 10, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants