Skip to content

Commit

Permalink
Fix setting EFFECTIVE_GROUP_ID to a list
Browse files Browse the repository at this point in the history
RT 134486

This is a regression introduced in 5.29.0
by 5d4a52b grok_atoUV: allow non-C strings and document

Making sure we backup the end pointer and restore it
before calling multiple times grok_atoUV should fix it.

URL: https://rt.perl.org/Ticket/Display.html?id=134486
  • Loading branch information
atoomic committed Oct 8, 2019
1 parent 92574b8 commit 15dbe1a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions mg.c
Original file line number Diff line number Diff line change
Expand Up @@ -3180,6 +3180,7 @@ Perl_magic_set(pTHX_ SV *sv, MAGIC *mg)
Groups_t *gary = NULL;
const char* p_end = p + len;
const char* endptr = p_end;
const char* backup_endptr = endptr;
UV uv;
#ifdef _SC_NGROUPS_MAX
int maxgrp = sysconf(_SC_NGROUPS_MAX);
Expand Down Expand Up @@ -3211,6 +3212,7 @@ Perl_magic_set(pTHX_ SV *sv, MAGIC *mg)
Newx(gary, i + 1, Groups_t);
else
Renew(gary, i + 1, Groups_t);
endptr = backup_endptr; /* we know where the end is */
if (grok_atoUV(p, &uv, &endptr))
gary[i] = (Groups_t)uv;
else {
Expand Down

6 comments on commit 15dbe1a

@bjornfor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this planned for backporting to a 5.30.x bugfix release? I'm asking because this fix seems necessary to unbreak munin.

@xsawyerx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be releasing 5.30.1 with this fix in.

@bjornfor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Any ETA on that?

@xsawyerx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're working on it at the moment. I cannot guarantee which day exactly yet.

@bjornfor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status of the 5.30.1 release? Is there a place where can see what's left to do?

@steve-m-hay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An RC1 is currently being prepared and should be released on Sunday 27th. The final release will be a week or probably two after that to allow time for testing -- or longer if any problems are found that warrant an RC2 etc.

Please sign in to comment.