Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create adapter utils shared lib #452

Merged
merged 4 commits into from
Feb 21, 2025
Merged

create adapter utils shared lib #452

merged 4 commits into from
Feb 21, 2025

Conversation

alexddobkin
Copy link
Collaborator

No description provided.

Copy link
Member

@timkpaine timkpaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add to:

@timkpaine
Copy link
Member

We should use this here too right? Right now it looks like we're building it but not linking against it

@alexddobkin
Copy link
Collaborator Author

We should use this here too right? Right now it looks like we're building it but not linking against it

are you referring to the new shared lib? we don't have to use it here, but need it for linking against in csp-internal

robambalu
robambalu previously approved these changes Feb 20, 2025
@robambalu
Copy link
Collaborator

@alexddobkin lets open an issue to get windows aligned, lets get this through for now

@robambalu robambalu self-requested a review February 21, 2025 18:44
@alexddobkin
Copy link
Collaborator Author

@alexddobkin lets open an issue to get windows aligned, lets get this through for now

already done #454

@alexddobkin alexddobkin merged commit c938b85 into main Feb 21, 2025
27 checks passed
@alexddobkin alexddobkin deleted the alexd/util_shared_lib branch February 21, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants