-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create adapter utils shared lib #452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add to:
-
csp/cpp/cmake/modules/FindCSP.cmake
Line 91 in 8a957cf
set(CSP_ADAPTER_UTILS_LIBRARY "${CSP_LIBS_DIR}/libcsp_adapter_utils_static.a") -
csp/cpp/cmake/modules/FindCSP.cmake
Line 125 in 8a957cf
find_library(CSP_ADAPTER_UTILS_LIBRARY NAMES libcsp_adapter_utils_static.a PATHS "${__csp_lib_path}" NO_DEFAULT_PATH)
Signed-off-by: alexd <[email protected]>
0b6de11
to
3c25c94
Compare
We should use this here too right? Right now it looks like we're building it but not linking against it |
are you referring to the new shared lib? we don't have to use it here, but need it for linking against in csp-internal |
Signed-off-by: alexd <[email protected]>
Signed-off-by: alexd <[email protected]>
Signed-off-by: alexd <[email protected]>
@alexddobkin lets open an issue to get windows aligned, lets get this through for now |
already done #454 |
No description provided.