fix: Don't delete existing flags on decide errors (#621)

PostHog · May 10, 2023 · 9774731 · 9774731
1 parent 6257540
commit 9774731
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/__tests__/featureflags.js b/src/__tests__/featureflags.js
@@ -701,6 +701,14 @@ describe('parseFeatureFlagDecideResponse', () => {
             $enabled_feature_flags: { 'beta-feature': true, 'alpha-feature-2': true },
         })
     })
+
+    it('doesnt remove existing feature flags when no flags are returned', () => {
+        given('decideResponse', () => ({ status: 0 }))
+        given.subject()
+
+        expect(given.persistence.register).not.toHaveBeenCalled()
+        expect(given.persistence.unregister).not.toHaveBeenCalled()
+    })
 })
 
 describe('filterActiveFeatureFlags', () => {

diff --git a/src/posthog-featureflags.ts b/src/posthog-featureflags.ts
@@ -69,12 +69,6 @@ export const parseFeatureFlagDecideResponse = (
                     [PERSISTENCE_FEATURE_FLAG_PAYLOADS]: newFeatureFlagPayloads || {},
                 })
         }
-    } else {
-        if (persistence) {
-            persistence.unregister(PERSISTENCE_ACTIVE_FEATURE_FLAGS)
-            persistence.unregister(ENABLED_FEATURE_FLAGS)
-            persistence.unregister(PERSISTENCE_FEATURE_FLAG_PAYLOADS)
-        }
     }
 }