-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[UI v2] feat: Start flow runs data table UX (#17168)
- Loading branch information
1 parent
9cc9ca8
commit 701e7f4
Showing
5 changed files
with
182 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
ui-v2/src/components/flow-runs/data-table/data-table.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import type { Meta, StoryObj } from "@storybook/react"; | ||
|
||
import { createFakeFlowRunWithDeploymentAndFlow } from "@/mocks/create-fake-flow-run"; | ||
import { routerDecorator } from "@/storybook/utils"; | ||
import { FlowRunsDataTable } from "./data-table"; | ||
|
||
const MOCK_DATA = Array.from( | ||
{ length: 5 }, | ||
createFakeFlowRunWithDeploymentAndFlow, | ||
); | ||
|
||
const meta: Meta<typeof FlowRunsDataTable> = { | ||
title: "Components/FlowRuns/DataTable/FlowRunsDataTable", | ||
decorators: [routerDecorator], | ||
args: { flowRuns: MOCK_DATA }, | ||
component: FlowRunsDataTable, | ||
}; | ||
export default meta; | ||
|
||
export const story: StoryObj = { name: "FlowRunsDataTable" }; |
100 changes: 100 additions & 0 deletions
100
ui-v2/src/components/flow-runs/data-table/data-table.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
import type { Deployment } from "@/api/deployments"; | ||
import { | ||
FlowRun, | ||
type FlowRunWithDeploymentAndFlow, | ||
type FlowRunWithFlow, | ||
} from "@/api/flow-runs"; | ||
import { DataTable } from "@/components/ui/data-table"; | ||
import { StateBadge } from "@/components/ui/state-badge"; | ||
import { TagBadgeGroup } from "@/components/ui/tag-badge-group"; | ||
import { | ||
createColumnHelper, | ||
getCoreRowModel, | ||
getPaginationRowModel, | ||
useReactTable, | ||
} from "@tanstack/react-table"; | ||
import { useMemo } from "react"; | ||
|
||
import { Flow } from "@/api/flows"; | ||
import { DeploymentCell } from "./deployment-cell"; | ||
import { NameCell } from "./name-cell"; | ||
|
||
export type FlowRunsDataTableRow = FlowRun & { | ||
flow: Flow; | ||
deployment?: Deployment; | ||
}; | ||
|
||
const columnHelper = createColumnHelper<FlowRunsDataTableRow>(); | ||
|
||
const createColumns = ({ | ||
showDeployment, | ||
}: { | ||
showDeployment: boolean; | ||
}) => { | ||
const ret = [ | ||
columnHelper.display({ | ||
id: "name", | ||
header: "Name", | ||
cell: ({ row }) => <NameCell flowRun={row.original} />, | ||
}), | ||
columnHelper.accessor("state", { | ||
id: "state", | ||
header: "State", | ||
cell: (props) => { | ||
const state = props.getValue(); | ||
if (!state) { | ||
return null; | ||
} | ||
return <StateBadge type={state.type} name={state.name} />; | ||
}, | ||
}), | ||
columnHelper.accessor("tags", { | ||
id: "tags", | ||
header: "Tags", | ||
cell: (props) => ( | ||
<TagBadgeGroup tags={props.getValue()} maxTagsDisplayed={4} /> | ||
), | ||
}), | ||
]; | ||
if (showDeployment) { | ||
ret.push( | ||
columnHelper.display({ | ||
id: "deployment", | ||
header: "Deployment", | ||
cell: ({ row }) => { | ||
const { deployment } = row.original; | ||
if (!deployment) { | ||
return null; | ||
} | ||
return <DeploymentCell deployment={deployment} />; | ||
}, | ||
}), | ||
); | ||
} | ||
return ret; | ||
}; | ||
|
||
type FlowRunsDataTableProps = { | ||
flowRuns: Array<FlowRunWithDeploymentAndFlow | FlowRunWithFlow>; | ||
}; | ||
export const FlowRunsDataTable = ({ flowRuns }: FlowRunsDataTableProps) => { | ||
const showDeployment = useMemo( | ||
() => flowRuns.some((flowRun) => "deployment" in flowRun), | ||
[flowRuns], | ||
); | ||
|
||
const table = useReactTable({ | ||
data: flowRuns, | ||
columns: createColumns({ | ||
showDeployment, | ||
}), | ||
getCoreRowModel: getCoreRowModel(), | ||
getPaginationRowModel: getPaginationRowModel(), // TODO: use server-side pagination | ||
}); | ||
|
||
return ( | ||
<div className="flex flex-col gap-4"> | ||
<DataTable table={table} /> | ||
</div> | ||
); | ||
}; |
20 changes: 20 additions & 0 deletions
20
ui-v2/src/components/flow-runs/data-table/deployment-cell.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { Deployment } from "@/api/deployments"; | ||
|
||
import { Icon } from "@/components/ui/icons"; | ||
import { Typography } from "@/components/ui/typography"; | ||
|
||
import { Link } from "@tanstack/react-router"; | ||
|
||
type DeploymentCellProps = { deployment: Deployment }; | ||
export const DeploymentCell = ({ deployment }: DeploymentCellProps) => { | ||
return ( | ||
<Link | ||
className="flex items-center gap-1 min-w-40" | ||
to="/deployments/deployment/$id" | ||
params={{ id: deployment.id }} | ||
> | ||
<Icon id="Rocket" className="h-4 w-4" /> | ||
<Typography variant="bodySmall">{deployment.name}</Typography> | ||
</Link> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
import { | ||
Breadcrumb, | ||
BreadcrumbItem, | ||
BreadcrumbLink, | ||
BreadcrumbList, | ||
BreadcrumbSeparator, | ||
} from "@/components/ui/breadcrumb"; | ||
import type { FlowRunsDataTableRow } from "./data-table"; | ||
|
||
type NameCellProps = { | ||
flowRun: FlowRunsDataTableRow; | ||
}; | ||
|
||
export const NameCell = ({ flowRun }: NameCellProps) => { | ||
return ( | ||
<div className="flex items-center min-w-40"> | ||
<Breadcrumb> | ||
<BreadcrumbList> | ||
<BreadcrumbItem> | ||
<BreadcrumbLink | ||
to="/flows/flow/$id" | ||
params={{ id: flowRun.flow_id }} | ||
> | ||
{flowRun.flow.name} | ||
</BreadcrumbLink> | ||
</BreadcrumbItem> | ||
|
||
<BreadcrumbSeparator>/</BreadcrumbSeparator> | ||
|
||
<BreadcrumbItem className="font-bold text-black"> | ||
<BreadcrumbLink to="/runs/flow-run/$id" params={{ id: flowRun.id }}> | ||
{flowRun.name} | ||
</BreadcrumbLink> | ||
</BreadcrumbItem> | ||
</BreadcrumbList> | ||
</Breadcrumb> | ||
</div> | ||
); | ||
}; |