consolidate pendulum use in prefect._internal
#17072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
changed the title
pendulum use in prefect._internal
zzstoatzz
force-pushed
the
pendulum-consolidation-5
branch
from
df314a9 to
219fa7a
Compare
CodSpeed Performance ReportMerging #17072 will not alter performanceComparing Summary
|
zzstoatzz
force-pushed
the
pendulum-consolidation-5
branch
2 times, most recently
from
2e3ad8a to
0047e73
Compare
zzstoatzz
force-pushed
the
pendulum-consolidation-5
branch
from
0047e73 to
fc84ce1
Compare
desertaxle
approved these changes
Feb 11, 2025
src/prefect/types/_datetime.py
Outdated
| return pendulum.tz.timezones() | ||
|
|
||
|
|
||
| def pendulum_instance(v: DateTime) -> DateTime: |
There was a problem hiding this comment.
Could we name this something like create_datetime_instance? Also, why do we need to call .instance twice?
There was a problem hiding this comment.
nice calls on both counts, I can just use the outside .instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on #16910