Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add links to CLI, API, Terraform, and Helm docs #17142

Merged
merged 18 commits into from
Feb 19, 2025

Conversation

mitchnielsen
Copy link
Contributor

@mitchnielsen mitchnielsen commented Feb 14, 2025

Related to https://linear.app/prefect/project/strengthen-the-connection-between-prefect-terraform-and-api-docs-1da6564ce040/overview

Provides references to the CLI, API, Terraform, and Helm docs where applicable to increase awareness of the options available for managing resources.

Adds snippets for references to each resource to keep things DRY.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@@ -0,0 +1,63 @@
export const home = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we define the links in one place and reuse them when we import the snippets. There may be a way to DRY this file up as well, but I haven't found something that works yet with mdx + URLs.

Comment on lines 36 to 56
## Considerations

Keep in mind the following when writing documentation.

### External references

Prefect resources can be managed in several ways, including through the CLI, UI, Terraform, Helm and API.

When documenting a resource, consider including external references that describe how to manage the resource in other ways.
Snippets are available to provide these references in a consistent format.

For example, the [Deployment documentation](/v3/deploy/index) includes a snippet for the Terraform provider:

```javascript
import { TF } from "/snippets/resource-management/terraform.mdx"
import { deployments } from "/snippets/resource-management/vars.mdx"

<TF name="deployments" href={deployments.tf} />
```

For more information on how to use snippets, see the [Mintlify documentation](https://mintlify.com/docs/reusable-snippets).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a section here to discuss how to use these snippets. Hopefully this will be a good reminder for future docs so we can keep using these references consistently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@@ -2,4 +2,4 @@

Thanks for considering contributing to Prefect!

To navigate our codebase with confidence, see our [contribution guidelines](https://docs.prefect.io/latest/contributing/overview/).
To navigate our codebase with confidence, see our [contribution guidelines](/contribute/index).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this link was broken.

@mitchnielsen
Copy link
Contributor Author

Alrighty, opening up for review.

FYI @jamiezieziula @zangell44 @olearycrew

@mitchnielsen mitchnielsen marked this pull request as ready for review February 14, 2025 18:31
Copy link
Contributor

@daniel-prefect daniel-prefect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mitchnielsen!

@mitchnielsen
Copy link
Contributor Author

@cicdw @desertaxle @zzstoatzz - looks like I need a review from one of y'all to proceed, thanks in advance 🤝

This file is hosted in GitHub, not the docs, so we need the full URL.

Co-authored-by: Alex Streed <[email protected]>
@mitchnielsen mitchnielsen merged commit 5f0f95d into main Feb 19, 2025
6 checks passed
@mitchnielsen mitchnielsen deleted the add-links-to-api-docs branch February 19, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants