respect aliases when loading custom logging.yaml
#17162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #17162 will not alter performanceComparing Summary
|
zzstoatzz
commented
Feb 17, 2025
zzstoatzz
force-pushed
the
17152
branch
3 times, most recently
from
bed05cc to
1a3aa1e
Compare
amgcc
reviewed
Feb 17, 2025
zzstoatzz
commented
Feb 17, 2025
zzstoatzz
commented
Feb 20, 2025
| @@ -92,6 +92,7 @@ def to_environment_variables( | |||
| self, | |||
| exclude_unset: bool = False, | |||
| include_secrets: bool = True, | |||
| include_aliases: bool = False, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17152
adds a new (default False) flag to
to_environment_variablesto dump alias keysalso adds type hints for all test cases in
test_logging