Add unit test for black formatting #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
reviewed
Oct 10, 2018
| @pytest.mark.skipif(sys.version_info < (3, 6), reason="Black requires Python 3.6+") | ||
| def test_black_formatting(): | ||
| # make sure we're in the right place | ||
| assert __file__.endswith("/tests/test_formatting.py") |
There was a problem hiding this comment.
Could you explain why this assert is necessary?
There was a problem hiding this comment.
I was worried that this file might get moved inadvertently, without someone necessarily looking at it (for example if the tests directory were restructured), and causing the following line (that runs black against the root) to fail. If there's a way to always get the repo root, I'd use that instead, but I'm not sure how.
There was a problem hiding this comment.
Ah ok that makes sense, otherwise you might accidentally black check a larger directory or something 👍
cicdw
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259.