Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run accidentally-skipped tests #3597

Merged
merged 1 commit into from
Oct 30, 2020
Merged

run accidentally-skipped tests #3597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/environments/execution/test_dask_k8s_environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def test_populate_worker_pod_yaml_with_private_registry():
):
yaml_obj = environment._populate_worker_pod_yaml(yaml_obj=pod)

yaml_obj["spec"]["imagePullSecrets"][0] == dict(name="foo-man-docker")
assert yaml_obj["spec"]["imagePullSecrets"][0] == dict(name="foo-man-docker")


def test_populate_worker_pod_yaml_with_image_pull_secret():
Expand All @@ -360,7 +360,7 @@ def test_populate_worker_pod_yaml_with_image_pull_secret():
):
yaml_obj = environment._populate_worker_pod_yaml(yaml_obj=pod)

yaml_obj["spec"]["imagePullSecrets"][0] == dict(name="mysecret")
assert yaml_obj["spec"]["imagePullSecrets"][0] == dict(name="mysecret")


def test_initialize_environment_with_spec_populates(monkeypatch):
Expand Down
2 changes: 1 addition & 1 deletion tests/schedules/test_schedules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def test_create_schedule_emits_events_if_asked():
assert all([isinstance(e, clocks.ClockEvent) for e in output])
assert all([e.parameter_defaults == dict() for e in output])

output == [dt.add(days=1), dt.add(days=2), dt.add(days=3)]
assert output == [dt.add(days=1), dt.add(days=2), dt.add(days=3)]


def test_create_schedule_multiple_overlapping_clocks():
Expand Down