Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter handlers #590

Merged
merged 8 commits into from
Jan 29, 2019
Merged

Parameter handlers #590

merged 8 commits into from
Jan 29, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jan 29, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

What does this PR change?

Fixes a bug in handle_inputs where result handlers weren't stored. Adds JSONResultHandler to all Parameters for when they need caching

Why is this PR important?

Just ensures that whenever Parameters are cached as inputs, they go directly to the DB for simplicity and a better user experience

@cicdw cicdw requested review from jlowin and joshmeek as code owners January 29, 2019 22:44
jlowin
jlowin previously approved these changes Jan 29, 2019
joshmeek
joshmeek previously approved these changes Jan 29, 2019
@cicdw cicdw dismissed stale reviews from joshmeek and jlowin via 03aa5f6 January 29, 2019 22:56
@cicdw cicdw merged commit 2770e7d into master Jan 29, 2019
@cicdw cicdw deleted the parameter-handlers branch January 29, 2019 23:29
cicdw added a commit that referenced this pull request Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants