Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)What does this PR change?
This PR updates heartbeats to ensure they are called multiple times on a fixed interval. Moreover, I updated the heartbeat tests to be more robust and truly test this functionality across executors, as well as in conjunction with timeouts.
Why is this PR important?
I began pulling this thread (pun intended) when wondering if heartbeats worked with timeouts, because they both do some multithreading / multiprocessing work under the hood. As I dove deeper, I realized that
threading.Timer
calls a function one time after a specified interval, so I fixed that by overriding therun
method ofthreading.Timer
.Doing this work reminded me that the
DaskExecutor(processes=True)
does not support task timeouts as I've implemented them. This is not a problem, but reminds me that we need to ensure our deployment executors are setup to match the full functionality in Core. In this case, the "deployed" analogue toprocesses=False
is the--no-nanny
flag on the dask workers.