Skip to content
This repository has been archived by the owner on Jun 1, 2021. It is now read-only.

Do not require storage of deliveryId in application-specific events #244

Closed
krasserm opened this issue Apr 1, 2016 · 0 comments · Fixed by #246
Closed

Do not require storage of deliveryId in application-specific events #244

krasserm opened this issue Apr 1, 2016 · 0 comments · Fixed by #246
Assignees
Milestone

Comments

@krasserm
Copy link
Contributor

krasserm commented Apr 1, 2016

Application-specific events used as confirmation events in context of ConfirmedDelivery shouldn't care about deliveryId storage (as extra field, for example). Instead, the following re-design of ConfirmedDelivery is proposed:

  • optional deliveryId field in DurableEvent
  • storage of confirmation events is done with persistConfirmation, a specialization of persist that has an extra deliveryId parameter. The persistConfirmation method is defined on ConfirmedDelivery.
  • event handlers don't have to call confirm any more. If a DurableEvent with a defined deliveryId is received, the corresponding reliable message is automatically removed from the internal delivery queue (if the event's emitterId equals the actor's id).
@krasserm krasserm self-assigned this Apr 1, 2016
@krasserm krasserm added this to the 0.7 milestone Apr 1, 2016
krasserm added a commit that referenced this issue Apr 11, 2016
- breaking change of confirmed delivery API
- closes #244
krasserm added a commit that referenced this issue Apr 12, 2016
- breaking change of confirmed delivery API
- closes #244
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant