Update INITIALIZE_PA_TUNING macro

[XScorpion2]

Added else statement to tell users what they did wrong.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced feedback during the pressure advance tuning process to clearly inform users when the printer does not meet the required conditions for starting the calibration.
  • Corrected a typo in the message for starting the pressure advance tuning tower from "presssure" to "pressure."

[coderabbitai]

Walkthrough

The change introduces an additional conditional branch into the INITIALIZE_PA_TUNING macro in configuration/macros/calibration.cfg. An else clause has been added so that if the printer is not actively printing G-code or if the layer number is 2 or greater, a message is output indicating that the pressure advance tuning tower can only start under the correct conditions. Additionally, a typo in the error message was corrected from "presssure" to "pressure." No modifications were made to any public or exported declarations.

Changes

File(s)	Change Summary
configuration/macros/calibration.cfg	Added a new else clause in the INITIALIZE_PA_TUNING macro that outputs an error message when the printer is not printing G-code or when on layer ≥2. Corrected a typo in the error message from "presssure" to "pressure."

Sequence Diagram(s)

sequenceDiagram
    participant P as Printer
    participant M as INITIALIZE_PA_TUNING Macro
    P->>M: Invoke INITIALIZE_PA_TUNING
    alt Conditions met (active printing & layer 1)
        M->>P: Start pressure advance tuning tower
    else Conditions not met
        M->>P: Output error message ("Requires active printing on layer 1")
    end

Loading

Poem

Hoppin' through lines of G-code delight,
I discovered a branch shining bright.
When printing's not live or the layer's too high,
A clear message comes fluttering by.
I'm the rabbit coder, joyful and spry—
Celebrating each update as time hops by! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4616915 and 884119b.

📒 Files selected for processing (1)

• configuration/macros/calibration.cfg (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• configuration/macros/calibration.cfg

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

configuration/macros/calibration.cfg (1)

87-88: Good addition for better error handling!

This else clause provides helpful feedback to users when they try to initialize pressure advance tuning under incorrect conditions. This improves the user experience by clearly explaining the requirements.

However, there's a minor typo in the message: "presssure" has three 's' characters instead of two. The same typo exists in the original message on line 85 as well.

-    	RATOS_ECHO MSG="Presssure advance tuning tower requires you to be printing gcode and on layer 1 to start."
+    	RATOS_ECHO MSG="Pressure advance tuning tower requires you to be printing gcode and on layer 1 to start."

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0617cc and 4616915.

📒 Files selected for processing (1)

• configuration/macros/calibration.cfg (1 hunks)

[XScorpion2]

Actionable comments posted: 0
🧹 Nitpick comments (1)

configuration/macros/calibration.cfg (1)> 87-88: Good addition for better error handling!

This else clause provides helpful feedback to users when they try to initialize pressure advance tuning under incorrect conditions. This improves the user experience by clearly explaining the requirements.
However, there's a minor typo in the message: "presssure" has three 's' characters instead of two. The same typo exists in the original message on line 85 as well.

-    	RATOS_ECHO MSG="Presssure advance tuning tower requires you to be printing gcode and on layer 1 to start."
+    	RATOS_ECHO MSG="Pressure advance tuning tower requires you to be printing gcode and on layer 1 to start."

📜 Review details

Hahahaha, this bot is awesome