Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(YouTube - Hide ads): Sponsored button ads in tablet mode search results #4352

Closed
3 tasks done
YoinkyS opened this issue Jan 25, 2025 · 2 comments · Fixed by #4330
Closed
3 tasks done

bug(YouTube - Hide ads): Sponsored button ads in tablet mode search results #4352

YoinkyS opened this issue Jan 25, 2025 · 2 comments · Fixed by #4330
Labels
Bug report Something isn't working

Comments

@YoinkyS
Copy link

YoinkyS commented Jan 25, 2025

Bug description

Image

Error logs



Solution


No response


Additional context


No response


Acknowledgements


    

  •  I have checked all open and closed bug reports and this is not a duplicate.
    • 

  •  I have chosen an appropriate title.
    • 

  •  All requested information has been provided properly.
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @YoinkyS
YoinkyS




          added
  the 

  Bug report

  Something isn't working
 label


      Jan 25, 2025

    

  



    

    

      
    

    


      

          @YoinkyS
YoinkyS




        changed the title
bug: Sponsored links still show up in search result in Tablet layout mode

bug: Sponsored links still show up in search result in Tablet layout mode (all ads removing options are turned on)


      Jan 25, 2025

    

  



  


  
    
  
  

    
  inotia00 

      added a commit
        to inotia00/revanced-patches
      that referenced
      this issue

    
      Jan 29, 2025
    
    

      


  

    

      


  

      
        @inotia00
  





      

        
          fix(YouTube - Hide ads): New types of ads are shown ReVanced/revanced…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          bfa7902
        
      

    

  

    

      
…-patches#4352

    




    

  









      

  
      



  

  @LisoUseInAIKyrios





  

    

      
  
  

    
      

        

              This comment has been minimized.

        

        

          Sign in to view
        

      

    
  



    













      

  
      



  

  @LisoUseInAIKyrios





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
Nevermind I could reproduce the issue.


There are two slightly different ad layouts and two filters are needed:


compact_landscape_image_layout.eml
text_image_no_button_layout.eml


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @LisoUseInAIKyrios
LisoUseInAIKyrios




        changed the title
bug: Sponsored links still show up in search result in Tablet layout mode (all ads removing options are turned on)

bug(YouTube - Hide ads): Sponsored button ads in tablet mode search results


      Jan 29, 2025

    

  



  

  

    
  


  

    


      @LisoUseInAIKyrios
LisoUseInAIKyrios



        linked a pull request
        Jan 29, 2025
        that will
        close
        this issue





  

    
      chore: Merge branch dev to main
      #4330
  



  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    1 task
  





  




    

    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    Bug report

  Something isn't working








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          
  

    

      

        
          

            
    

    Development
  




              
  
Successfully merging a pull request may close this issue.





    


  
          
      chore: Merge branch dev to main

    
      ReVanced/revanced-patches
    





        
      

    

  


      

    

  
      

  

    

      2 participants
    

    

        
          @LisoUseInAIKyrios 
        
          @YoinkyS