Update charge after using the NH3_elimination families #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoruiDong
previously approved these changes
Oct 22, 2018
|
Thanks for approving! We'll wait with merging until the -db branch is approved as well. |
Codecov Report
@@ Coverage Diff @@
## master #1496 +/- ##
==========================================
+ Coverage 41.58% 41.59% +0.01%
==========================================
Files 176 176
Lines 29147 29147
Branches 5995 5995
==========================================
+ Hits 12120 12125 +5
+ Misses 16187 16183 -4
+ Partials 840 839 -1
Continue to review full report at Codecov.
|
5 tasks
mliu49
requested changes
Apr 30, 2019
mliu49
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a sibling PR (ReactionMechanismGenerator/RMG-database#296) we introduce two new families,
1,2_NH3_eliminationand1,3 NH3_elimination. This PR adds them to the list of families for which the formal charges of the products must be updated. We should merge this PR before merging the related database one.