Skip to content

Commit

Permalink
test(expand): add more marble tests for expand()
Browse files Browse the repository at this point in the history 
Add subscription assertions on expand tests. Add concurrency-related tests.
  • Loading branch information
@staltz @kwonoj
staltz authored and kwonoj committed Nov 30, 2015
1 parent 12eb98e commit 4411e1f
Showing 1 changed file with 216 additions and 9 deletions.
225 changes: 216 additions & 9 deletions spec/operators/expand-spec.js
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* globals describe, it, expect, expectObservable, hot, cold */
/* globals describe, it, expect, expectObservable, expectSubscriptions, hot, cold */
var Rx = require('../../dist/cjs/Rx');
var Observable = Rx.Observable;
var Promise = require('promise');
Expand All @@ -12,7 +12,10 @@ describe('Observable.prototype.expand()', function () {
d: 4 + 4, // c + c,
e: 8 + 8, // d + d
};
var e1 = hot('(a|)', values);
var e1 = hot('(a|)', values);
var e1subs = '^ ! ';
var e2shape = '---(z|) ';
var expected = 'a--b--c--d--(e|)';
/*
expectation explanation: (conjunction junction?) ...
Expand All @@ -27,14 +30,214 @@ describe('Observable.prototype.expand()', function () {
---(e|) (...which flattens into:)
a--b--c--d--(e|)
*/
var expected = 'a--b--c--d--(e|)';

expectObservable(e1.expand(function (x) {
var result = e1.expand(function (x) {
if (x === 16) {
return Observable.empty();
}
return cold('---(z|)', { z: x + x });
})).toBe(expected, values);
return cold(e2shape, { z: x + x });
});

expectObservable(result).toBe(expected, values);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should map and recursively flatten, and handle event raised error', function () {
var values = {
a: 1,
b: 1 + 1, // a + a,
c: 2 + 2, // b + b,
d: 4 + 4, // c + c,
e: 8 + 8, // d + d
};
var e1 = hot('(a|)', values);
var e1subs = '^ ! ';
var e2shape = '---(z|) ';
var expected = 'a--b--c--(d#)';

var result = e1.expand(function (x) {
if (x === 8) {
return cold('#');
}
return cold(e2shape, { z: x + x });
});

expectObservable(result).toBe(expected, values);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should map and recursively flatten, and propagate error thrown from projection', function () {
var values = {
a: 1,
b: 1 + 1, // a + a,
c: 2 + 2, // b + b,
d: 4 + 4, // c + c,
e: 8 + 8, // d + d
};
var e1 = hot('(a|)', values);
var e1subs = '^ ! ';
var e2shape = '---(z|) ';
var expected = 'a--b--c--(d#)';

var result = e1.expand(function (x) {
if (x === 8) {
throw 'error';
}
return cold(e2shape, { z: x + x });
});

expectObservable(result).toBe(expected, values);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should allow unsubscribing early', function () {
var values = {
a: 1,
b: 1 + 1, // a + a,
c: 2 + 2, // b + b,
d: 4 + 4, // c + c,
e: 8 + 8, // d + d
};
var e1 = hot('(a|)', values);
var unsub = ' ! ';
var e1subs = '^ ! ';
var e2shape = '---(z|) ';
var expected = 'a--b--c- ';

var result = e1.expand(function (x) {
if (x === 16) {
return Observable.empty();
}
return cold(e2shape, { z: x + x });
});

expectObservable(result, unsub).toBe(expected, values);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should allow concurrent expansions', function () {
var values = {
a: 1,
b: 1 + 1, // a + a,
c: 2 + 2, // b + b,
d: 4 + 4, // c + c,
e: 8 + 8, // d + d
};
var e1 = hot('a-a| ', values);
var e1subs = '^ ! ';
var e2shape = '---(z|) ';
var expected = 'a-ab-bc-cd-de-(e|)';

var result = e1.expand(function (x) {
if (x === 16) {
return Observable.empty();
}
return cold(e2shape, { z: x + x });
});

expectObservable(result).toBe(expected, values);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should allow configuring the concurrency limit parameter to 1', function () {
var values = {
a: 1,
b: 1 + 1, // a + a,
c: 2 + 2, // b + b,
d: 4 + 4, // c + c,
e: 8 + 8, // d + d
u: 10,
v: 20, // u + u
x: 40, // v + v
y: 80, // x + x
z: 160, // y + y
};
var e1 = hot('a-u|', values);
var e2shape = '---(z|)';
// ---(z|)
// ---(z|)
// ---(z|)
// ---(z|)
// ---(z|)
// ---(z|)
// ---(z|)
// Notice how for each column, there is at most 1 `-` character.
var e1subs = '^ ! ';
var expected = 'a--u--b--v--c--x--d--y--(ez|)';
var concurrencyLimit = 1;

var result = e1.expand(function (x) {
if (x === 16 || x === 160) {
return Observable.empty();
}
return cold(e2shape, { z: x + x });
}, concurrencyLimit);

expectObservable(result).toBe(expected, values);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should allow configuring the concurrency limit parameter to 2', function () {
var values = {
a: 1,
b: 1 + 1, // a + a,
c: 2 + 2, // b + b,
u: 10,
v: 20, // u + u
x: 40, // v + v
};
var e1 = hot('a---au|', values);
var e2shape = '------(z|)';
// ------(z|)
// ------(z|)
// ------(z|)
// ------(z|)
// ------(z|)
// ------(z|)
// Notice how for each column, there is at most 2 `-` characters.
var e1subs = '^ ! ';
var expected = 'a---a-u---b-b---v-(cc)(x|)';
var concurrencyLimit = 2;

var result = e1.expand(function (x) {
if (x === 4 || x === 40) {
return Observable.empty();
}
return cold(e2shape, { z: x + x });
}, concurrencyLimit);

expectObservable(result).toBe(expected, values);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should ignore concurrency limit if it is not passed', function () {
var values = {
a: 1,
b: 1 + 1, // a + a,
c: 2 + 2, // b + b,
d: 4 + 4, // c + c,
e: 8 + 8, // d + d
u: 10,
v: 20, // u + u
x: 40, // v + v
y: 80, // x + x
z: 160, // y + y
};
var e1 = hot('a-u| ', values);
var e1subs = '^ ! ';
var e2shape = '---(z|) ';
var expected = 'a-ub-vc-xd-ye-(z|)';
var concurrencyLimit = 100;

var result = e1.expand(function (x) {
if (x === 16 || x === 160) {
return Observable.empty();
}
return cold(e2shape, { z: x + x });
}, concurrencyLimit);

expectObservable(result).toBe(expected, values);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should map and recursively flatten with scalars', function () {
Expand All @@ -45,15 +248,19 @@ describe('Observable.prototype.expand()', function () {
d: 4 + 4, // c + c,
e: 8 + 8, // d + d
};
var e1 = hot('(a|)', values);
var e1 = hot('(a|)', values);
var e1subs = '(^!)';
var expected = '(abcde|)';

expectObservable(e1.expand(function (x) {
var result = e1.expand(function (x) {
if (x === 16) {
return Observable.empty();
}
return Observable.of(x + x); // scalar
})).toBe(expected, values);
});

expectObservable(result).toBe(expected, values);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should recursively flatten promises', function (done) {
Expand Down

0 comments on commit 4411e1f

Please sign in to comment.