Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUST KILL NO SPACE BRACES #1868

Closed
benlesh opened this issue Aug 5, 2016 · 11 comments
Closed

MUST KILL NO SPACE BRACES #1868

benlesh opened this issue Aug 5, 2016 · 11 comments
Assignees

Comments

@benlesh
Copy link
Member

benlesh commented Aug 5, 2016

This is a special issue for @ladyleet, who wants to contribute in a meaningful way.

I HATE no space imports in our files. I hate them. We all hate them. @jayphelps hates them. @kwonoj hates them. There's so much hate. End our hate, Tracy. End it.

You wanted to contribute, @ladyleet, here it is... kill those no-space imports!

GOOD:

 import { foo } from 'foo';

BAD:

import {foo} from 'foo';

related #1867

@benlesh benlesh self-assigned this Aug 5, 2016
@benlesh
Copy link
Member Author

benlesh commented Aug 5, 2016

I'm assigning myself so no one else takes this one up. But it's all you, @ladyleet.

MehulATL added a commit to MehulATL/rxjs that referenced this issue Aug 5, 2016
Add spaces to import statement on line 44 as per issue ReactiveX#1868.
@trxcllnt
Copy link
Member

trxcllnt commented Aug 5, 2016

lol I thought that was how you liked it since I saw it done everywhere.

@jayphelps
Copy link
Member

image

@ladyleet
Copy link
Member

ladyleet commented Aug 5, 2016

@jayphelps you're way more interesting on github than twitter. i'm kind of digging it.

@jayphelps
Copy link
Member

@ladyleet github is life

benlesh pushed a commit that referenced this issue Aug 6, 2016
Add spaces to import statement on line 44 as per issue #1868.
@staltz
Copy link
Member

staltz commented Aug 9, 2016

I love import {foo} from 'foo';. Seriously.

@benlesh
Copy link
Member Author

benlesh commented Aug 9, 2016

NO @staltz! I'll accept your Finnish Notation, but you can't have no-space-braces! You can't! 😤

@staltz
Copy link
Member

staltz commented Aug 9, 2016

Yeah, I understand you americans. Inches, Fahrenheit, Feet, AM/PM, Miles. And now... spaces for braces. I guess if you use wrong standards, you gotta consciously and consistently use wrong standards everywhere. :)

</sarcasm>

@benlesh
Copy link
Member Author

benlesh commented Aug 9, 2016

@staltz: Trump's nukes won't care if they miss by inches or centimeters. The end is nigh.

@staltz
Copy link
Member

staltz commented Aug 10, 2016

But heating something up to 100 degrees (Celsius? Fahrenheit?) might mean life or death.

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants