fix(schedulers): Fix Asap and AnimationFrame Schedulers to act like the Async Scheduler if delay > 0 #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
force-pushed
the
fix-scheduler-flush-action-arg
branch
from
04effb6 to
19b9c13
Compare
trxcllnt
force-pushed
the
fix-scheduler-flush-action-arg
branch
from
19b9c13 to
12a34ec
Compare
kwonoj
reviewed
Sep 18, 2016
| @@ -20,6 +20,19 @@ describe('Scheduler.animationFrame', () => { | |||
| } | |||
| }); | |||
|
|
|||
| it('should act like the async scheduler if delay > 0', (done: MochaDone) => { | |||
There was a problem hiding this comment.
I'd like to suggest to use fakeTimer same as other test case (here) to avoid intermittent test failure by timing condition of test execution environment (usually occurs on mobile emulator browser test)
trxcllnt
force-pushed
the
fix-scheduler-flush-action-arg
branch
from
12a34ec to
2441ed0
Compare
trxcllnt
force-pushed
the
fix-scheduler-flush-action-arg
branch
from
2441ed0 to
be544f1
Compare
trxcllnt
force-pushed
the
fix-scheduler-flush-action-arg
branch
from
be544f1 to
33e4bed
Compare
|
@jayphelps sure thing |
… Async if delay > 0
trxcllnt
force-pushed
the
fix-scheduler-flush-action-arg
branch
from
33e4bed to
d5c682c
Compare
|
@jayphelps Scheduler with Observable tests added in |
|
LGTM |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Asap and AnimationFrame Schedulers should act like the Async Scheduler if delay > 0.
Related issue (if exists):
#1952