Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks page to show active, pending and blocked tasks for self #31

Merged
merged 15 commits into from
Apr 8, 2021

Conversation

sumitd94
Copy link
Contributor

@sumitd94 sumitd94 commented Feb 10, 2021

A page where you can view and edit your own tasks' progress

Raw setup was done by @sumitd94 and taken forward by @swarajpure

image

@sumitd94 sumitd94 requested a review from swarajpure February 10, 2021 09:35
@sumitd94 sumitd94 changed the title Tasks route Tasks route - WIP Feb 10, 2021
@swarajpure swarajpure self-assigned this Feb 22, 2021
@swarajpure swarajpure added the feature task A big ticket item that needs to come up as a feature label Feb 22, 2021
@swarajpure
Copy link
Contributor

Preview:
https://media.discordapp.net/attachments/781622711436050463/813502850545352754/my-tasks-progress.gif?width=1329&height=611

@swarajpure
Copy link
Contributor

Update:

@swarajpure
Copy link
Contributor

swarajpure commented Feb 23, 2021

To do:

  • Clean the template - a lot of repetition of code
    - [ ] Fetch completed tasks efficiently - currently we are fetching completed tasks on every click on Completed Tasks
    (completed tasks will be a different PR 😉)

@swarajpure swarajpure changed the title Tasks route - WIP Tasks page to show active, pending and blocked tasks for self Feb 26, 2021
Copy link
Contributor

@ankushdharkar ankushdharkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs discussion over some of the implementations.

Copy link
Contributor

@swarajpure swarajpure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made many changes as requested. Will need to have a discussion to resolve rest of the comments

@swarajpure swarajpure requested a review from ankushdharkar March 5, 2021 10:24
Copy link
Contributor

@akankshadharkar akankshadharkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of suggestions:

I see a lot of places redefining the four states ACTIVE, BLOCKED, COMPLETED, PENDING
Do you think it would be better to extract it out in a constants file and use them from there?
I feel that will help improve maintainability and introduces new changes/states faster in the future if required

@swarajpure
Copy link
Contributor

Looks good, just a couple of suggestions:

I see a lot of places redefining the four states ACTIVE, BLOCKED, COMPLETED, PENDING
Do you think it would be better to extract it out in a constants file and use them from there?
I feel that will help improve maintainability and introduces new changes/states faster in the future if required

They're already coming from a constants file. Please check 😁

@akankshadharkar
Copy link
Contributor

Looks good, just a couple of suggestions:
I see a lot of places redefining the four states ACTIVE, BLOCKED, COMPLETED, PENDING
Do you think it would be better to extract it out in a constants file and use them from there?
I feel that will help improve maintainability and introduces new changes/states faster in the future if required

They're already coming from a constants file. Please check 😁

Yes, I see they're coming from ENV.TASK_STATUS but in a few files, it's being deconstructed everytime and I feel that tomorrow when(if) we add a new state, we'll have to ensure to add it in all deconstructed variables
Instead we can deconstruct it once in a constants file and use it from there directly wherever required
CC @ankushdharkar

@swarajpure
Copy link
Contributor

Changed the design of task card to our universal card style 😛
Top card: on hover
Bottom card: normal

image

Comment on lines +2 to +3
<p class="task-details__title"><b>Title: </b>{{@task.title}}</p>
<p class="task-details__purpose"><b>Purpose: </b>{{@task.purpose}}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@akankshadharkar akankshadharkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes 😄

@akankshadharkar akankshadharkar merged commit 5200135 into Real-Dev-Squad:develop Apr 8, 2021
@swarajpure swarajpure linked an issue Apr 8, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature task A big ticket item that needs to come up as a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create /tasks page
4 participants