-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks page to show active, pending and blocked tasks for self #31
Conversation
To do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs discussion over some of the implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made many changes as requested. Will need to have a discussion to resolve rest of the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of suggestions:
I see a lot of places redefining the four states ACTIVE, BLOCKED, COMPLETED, PENDING
Do you think it would be better to extract it out in a constants file and use them from there?
I feel that will help improve maintainability and introduces new changes/states faster in the future if required
They're already coming from a constants file. Please check 😁 |
Yes, I see they're coming from ENV.TASK_STATUS but in a few files, it's being deconstructed everytime and I feel that tomorrow when(if) we add a new state, we'll have to ensure to add it in all deconstructed variables |
<p class="task-details__title"><b>Title: </b>{{@task.title}}</p> | ||
<p class="task-details__purpose"><b>Purpose: </b>{{@task.purpose}}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the changes 😄
A page where you can view and edit your own tasks' progress
Raw setup was done by @sumitd94 and taken forward by @swarajpure