-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: split out demos #1291
docs: split out demos #1291
Conversation
🦋 Changeset detectedLatest commit: 3954d54 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +2.57 kB (+1%) Total Size: 209 kB
ℹ️ View Unchanged
|
873e903
to
94ea6e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeroedin same issue with footer, problem exists in prod |
Ok so pretty much anywhere an icon is being loaded, also see it now in |
With the split out demos does it make sense on the dev server index view to hide the long lists with a disclosure? This can also be split out to a separate PR, not a blocker. |
Just to be clear the elements I put my @zeroedin next to in the PR description have been reviewed and ✅ approved by me I assume thats what we were going for here. Taking a look at the non component changes now, then will approve the PR or comment more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines glanced... Thursday malaise
What I did