fix: fix 'span' to 'li' (ant-design#40867)

RedJue · Apr 25, 2023 · 2d03c28 · 2d03c28
1 parent 786b248
commit 2d03c28
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 17 deletions.
diff --git a/components/breadcrumb/BreadcrumbSeparator.tsx b/components/breadcrumb/BreadcrumbSeparator.tsx
@@ -10,7 +10,11 @@ const BreadcrumbSeparator: CompoundedComponent = ({ children }) => {
   const { getPrefixCls } = React.useContext(ConfigContext);
   const prefixCls = getPrefixCls('breadcrumb');
 
-  return <span className={`${prefixCls}-separator`}>{children || '/'}</span>;
+  return (
+    <li className={`${prefixCls}-separator`} aria-hidden="true">
+      {children || '/'}
+    </li>
+  );
 };
 
 BreadcrumbSeparator.__ANT_BREADCRUMB_SEPARATOR = true;

diff --git a/components/breadcrumb/__tests__/__snapshots__/Breadcrumb.test.tsx.snap b/components/breadcrumb/__tests__/__snapshots__/Breadcrumb.test.tsx.snap
@@ -12,11 +12,12 @@ exports[`Breadcrumb filter React.Fragment 1`] = `
         Location
       </span>
     </li>
-    <span
+    <li
+      aria-hidden="true"
       class="ant-breadcrumb-separator"
     >
       :
-    </span>
+    </li>
     <li>
       <a
         class="ant-breadcrumb-link"
@@ -25,11 +26,12 @@ exports[`Breadcrumb filter React.Fragment 1`] = `
         Application Center
       </a>
     </li>
-    <span
+    <li
+      aria-hidden="true"
       class="ant-breadcrumb-separator"
     >
       /
-    </span>
+    </li>
   </ol>
 </nav>
 `;

diff --git a/components/breadcrumb/__tests__/__snapshots__/demo-extend.test.ts.snap b/components/breadcrumb/__tests__/__snapshots__/demo-extend.test.ts.snap
@@ -396,11 +396,12 @@ exports[`renders ./components/breadcrumb/demo/separator-component.tsx extend con
         Location
       </span>
     </li>
-    <span
+    <li
+      aria-hidden="true"
       class="ant-breadcrumb-separator"
     >
       :
-    </span>
+    </li>
     <li>
       <a
         class="ant-breadcrumb-link"
@@ -409,11 +410,12 @@ exports[`renders ./components/breadcrumb/demo/separator-component.tsx extend con
         Application Center
       </a>
     </li>
-    <span
+    <li
+      aria-hidden="true"
       class="ant-breadcrumb-separator"
     >
       /
-    </span>
+    </li>
     <li>
       <a
         class="ant-breadcrumb-link"
@@ -422,11 +424,12 @@ exports[`renders ./components/breadcrumb/demo/separator-component.tsx extend con
         Application List
       </a>
     </li>
-    <span
+    <li
+      aria-hidden="true"
       class="ant-breadcrumb-separator"
     >
       /
-    </span>
+    </li>
     <li>
       <span
         class="ant-breadcrumb-link"

diff --git a/components/breadcrumb/__tests__/__snapshots__/demo.test.ts.snap b/components/breadcrumb/__tests__/__snapshots__/demo.test.ts.snap
@@ -224,11 +224,12 @@ exports[`renders ./components/breadcrumb/demo/separator-component.tsx correctly
         Location
       </span>
     </li>
-    <span
+    <li
+      aria-hidden="true"
       class="ant-breadcrumb-separator"
     >
       :
-    </span>
+    </li>
     <li>
       <a
         class="ant-breadcrumb-link"
@@ -237,11 +238,12 @@ exports[`renders ./components/breadcrumb/demo/separator-component.tsx correctly
         Application Center
       </a>
     </li>
-    <span
+    <li
+      aria-hidden="true"
       class="ant-breadcrumb-separator"
     >
       /
-    </span>
+    </li>
     <li>
       <a
         class="ant-breadcrumb-link"
@@ -250,11 +252,12 @@ exports[`renders ./components/breadcrumb/demo/separator-component.tsx correctly
         Application List
       </a>
     </li>
-    <span
+    <li
+      aria-hidden="true"
       class="ant-breadcrumb-separator"
     >
       /
-    </span>
+    </li>
     <li>
       <span
         class="ant-breadcrumb-link"