-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add methods to remove existing failure modes #1068
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
==========================================
+ Coverage 95.46% 95.59% +0.12%
==========================================
Files 155 155
Lines 5582 5586 +4
Branches 611 612 +1
==========================================
+ Hits 5329 5340 +11
+ Misses 226 221 -5
+ Partials 27 25 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.14%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
SonarCloud Quality Gate failed.
|
Does this PR introduce a breaking change?
Describe the purpose of this pull request.
To remove existing failure modes whenever a component's category or subcategory change.
Describe how this was implemented.
Added two methods to the FMEA panel to respond to category and subcategory changes. These are wrappers for the method that requests deletion of each mode and clearing the FMEA worksheet.
Describe any particular area(s) reviewers should focus on.
None
Provide any other pertinent information.
Closes #32
Pull Request Checklist
Code Style
Static Checks
this PR.
Tests
Chores
this PR. These problem areas have been decorated with an ISSUE: # comment.