Paywall events: Send paywall data with post receipt requests #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1452 +/- ##
=======================================
Coverage 83.99% 84.00%
=======================================
Files 206 208 +2
Lines 6843 6888 +45
Branches 992 999 +7
=======================================
+ Hits 5748 5786 +38
- Misses 705 712 +7
Partials 390 390
☔ View full report in Codecov by Sentry. |
NachoSoto
approved these changes
Nov 9, 2023
| import com.revenuecat.purchases.paywalls.events.PaywallEventType | ||
|
|
||
| @OptIn(ExperimentalPreviewRevenueCatPurchasesAPI::class) | ||
| internal class PaywallPresentedCache { |
There was a problem hiding this comment.
This is a nice abstraction!
Comment on lines
+15
to
+18
| val event = lastPaywallImpressionEvent | ||
| lastPaywallImpressionEvent = null | ||
| return event |
There was a problem hiding this comment.
This is technically a race condition. Is it possible to synchronize getAndRemovePresentedEvent instead?
There was a problem hiding this comment.
Right! We can synchronize the methods instead. Great catch!
| storeAppUserID = any(), | ||
| marketplace = any(), | ||
| initiationSource = any(), | ||
| paywallPostReceiptData = expectedPaywallData, |
tonidero
force-pushed
the
toniricodiez/pwl-321-paywall-events-5
branch
from
ecf55d6 to
20707b9
Compare
vegaro
approved these changes
Nov 10, 2023
Base automatically changed from
toniricodiez/pwl-321-paywall-events-5
to
main
November 10, 2023 09:52
tonidero
force-pushed
the
toniricodiez/pwl-321-paywall-events-6
branch
from
cc98c49 to
ff488da
Compare
tonidero
pushed a commit
that referenced
this pull request
Nov 10, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: improve error log when images fail to load (#1454) via NachoSoto (@NachoSoto) ### Other Changes * Paywall events: Send paywall data with post receipt requests (#1452) via Toni Rico (@tonidero) * Paywalls: Track paywall events (#1447) via Toni Rico (@tonidero) * Paywall events: Handle errors parsing specific paywall event lines (#1451) via Toni Rico (@tonidero) * Paywalls: Move logic for events file helper to common generic class (4) (#1446) via Toni Rico (@tonidero) * Paywalls: Add paywall events flush logic and tests (3) (#1445) via Toni Rico (@tonidero) * Paywalls: Support sending paywall events to servers (2) (#1442) via Toni Rico (@tonidero) * `CircleCI`: fix `record-revenuecatui-snapshots` (#1455) via NachoSoto (@NachoSoto) * Lower request jitter log level from warning to debug (#1453) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sends the paywall data during the post receipt requests to make sure we attribute purchases to paywalls. We do this by caching the paywall events as needed.