Paywalls: Support condensed footer in template 4 #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
commented
Nov 14, 2023
| textAlign = TextAlign.Center, | ||
| modifier = Modifier.fillMaxWidth(), | ||
| ) | ||
| Column(horizontalAlignment = Alignment.CenterHorizontally) { |
There was a problem hiding this comment.
I needed to wrap these into another column like this to avoid the outer column verticalArrangement spacing. Seems like the AnimatedVisibility jumps when trying to animate an item disappearing and that spacing going away. I'm mimicking that by manually handling the animation of a custom Spacer here.
There was a problem hiding this comment.
Seems like the AnimatedVisibility jumps when trying to animate an item disappearing and that spacing going away
Yeah that's why we can't use it in many place where e need spacing to remain consistent.
NachoSoto
approved these changes
Nov 14, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Nov 14, 2023
**This is an automatic release.** ### RevenueCatUI * Paywalls: fix template 5 header aspect ratio (#1465) via NachoSoto (@NachoSoto) * Paywalls: Fix template 1 header aspect ratio (#1466) via Toni Rico (@tonidero) * Paywalls: Support condensed footer in template 4 (#1469) via Toni Rico (@tonidero) * `Paywalls`: improve image loading (#1464) via NachoSoto (@NachoSoto) * `Paywalls`: override locale with paywall localization (#1418) via NachoSoto (@NachoSoto) ### Other Changes * Paywalls: Fix purchasing regression by providing real activity (#1467) via Toni Rico (@tonidero) * Bump compile/target version to 34 (#1462) via Toni Rico (@tonidero) * Update circleci orb to latest version (#1456) via Toni Rico (@tonidero) * `Snapshots`: fix Fastlane job (#1461) via NachoSoto (@NachoSoto) * Update gradle plugin to version 8.1.1 (#1458) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Template 4 did not support condensed footer mode. This adds it with a simple slide up-down animation.
Screen_recording_20231114_152339.mp4