Report restore errors when using PaywallActivityLauncher #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
=======================================
Coverage 84.14% 84.14%
=======================================
Files 218 218
Lines 7196 7196
Branches 1007 1007
=======================================
Hits 6055 6055
Misses 750 750
Partials 391 391 ☔ View full report in Codecov by Sentry. |
vegaro
approved these changes
Jan 3, 2024
vegaro
pushed a commit
that referenced
this pull request
Jan 3, 2024
**This is an automatic release.** ### RevenueCatUI * PaywallActivityLauncher: Add callback indicating whether the paywall was displayed when presented conditionally to an entitlement identifier (#1542) via Toni Rico (@tonidero) * Report restore errors when using PaywallActivityLauncher (#1544) via Toni Rico (@tonidero) * Remove scroll in Template 2 and 5 in Footer mode (#1545) via Cesar de la Vega (@vegaro) ### Bugfixes * Opens PaywallFooterView (#1541) via Cesar de la Vega (@vegaro) ### Dependency Updates * Bump fastlane from 2.217.0 to 2.218.0 (#1543) via dependabot[bot] (@dependabot[bot]) Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
PaywallActivityLauncherresult, we were only reporting errors happening during purchasing, but not when an error happened during restores.This PR fixes that so we also report restore errors as long as that's the last operation that happened before closing the paywall.