Fix paywall product name variable to not include app name #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add-name-to-store-product #1569 +/- ##
==========================================================
Coverage 83.72% 83.72%
==========================================================
Files 218 218
Lines 7246 7246
Branches 1007 1007
==========================================================
Hits 6067 6067
Misses 788 788
Partials 391 391 ☔ View full report in Codecov by Sentry. |
NachoSoto
approved these changes
Jan 25, 2024
NachoSoto
added a commit
that referenced
this pull request
Jan 25, 2024
This seemed to have been a bad merge from #1569.
NachoSoto
added a commit
that referenced
this pull request
Jan 25, 2024
This seemed to have been a bad merge from #1569.
NachoSoto
pushed a commit
that referenced
this pull request
Jan 25, 2024
**This is an automatic release.** ### New Features * Add name property to StoreProduct (#1567) via Toni Rico (@tonidero) ### RevenueCatUI * Fix paywall product name variable to not include app name (#1569) via Toni Rico (@tonidero) ### Bugfixes * Use activity instead of context to calculate window size (#1570) via Toni Rico (@tonidero) ### Other Changes * `VariableProcessor`: fix tests (#1572) via NachoSoto (@NachoSoto) Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #1567
Until now we were using Google's
titleproperty which includes the app name, which might not look great in paywalls. Using thenameproperty added in #1567, we now will be using the name of the subscription directly