Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paywalls: Allow closed button color to be configured #1674

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

joshdholtz
Copy link
Member

Motivation

Allow dialog paywall view to have a custom close button color from the dashboard

Description

  • New close_button color

@joshdholtz joshdholtz added the pr:feat A new feature label Apr 11, 2024
@joshdholtz joshdholtz requested a review from a team April 11, 2024 19:40
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.37%. Comparing base (0162a16) to head (2c81b81).
Report is 2 commits behind head on main.

Files Patch % Lines
...n/com/revenuecat/purchases/paywalls/PaywallData.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
- Coverage   83.38%   83.37%   -0.02%     
==========================================
  Files         220      220              
  Lines        7486     7487       +1     
  Branches     1053     1053              
==========================================
  Hits         6242     6242              
- Misses        830      831       +1     
  Partials      414      414              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a comment.

@joshdholtz joshdholtz merged commit eebcf90 into main Apr 15, 2024
9 checks passed
@joshdholtz joshdholtz deleted the paywalls-close-button-color-configuration branch April 15, 2024 16:02
tonidero pushed a commit that referenced this pull request Apr 18, 2024
**This is an automatic release.**

### New Features
* Paywalls: Allow closed button color to be configured (#1674) via Josh
Holtz (@joshdholtz)
### Other Changes
* Add offline entitlements diagnostics events (#1671) via Toni Rico
(@tonidero)

Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants