Adds some more test cases validating {{ total_price_and_per_month }} for quarterly packages. #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for quarterly pacakges.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1853 +/- ##
=======================================
Coverage 82.80% 82.80%
=======================================
Files 222 222
Lines 7689 7689
Branches 1084 1084
=======================================
Hits 6367 6367
Misses 899 899
Partials 423 423
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Sep 25, 2024
tonidero
pushed a commit
that referenced
this pull request
Sep 26, 2024
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add `kochava` integration (#1844) via Toni Rico (@tonidero) ## RevenueCatUI SDK ### 🐞 Bugfixes * Fix multiple paywalls display issues (#1854) via Toni Rico (@tonidero) * Fix interaction not disabled during purchases (#1850) via Toni Rico (@tonidero) * Fix crash if activity finished while calculating presentation logic (#1846) via Toni Rico (@tonidero) ### 🔄 Other Changes * Adds some more test cases validating {{ total_price_and_per_month }} for quarterly packages. (#1853) via JayShortway (@JayShortway) * Converts CustomEntitlementComputationSample's Gradle files to Kotlin (#1852) via JayShortway (@JayShortway) * Converts MagicWeatherCompose's Gradle files to Kotlin (#1851) via JayShortway (@JayShortway) * [EXTERNAL] Wireup Emerge gradle plugin config for PR snapshot diffs (#1841) by @rbro112 (#1843) via Toni Rico (@tonidero) * Bump fastlane-plugin-revenuecat_internal from `5140dbc` to `55a0455` (#1845) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. When investigating an issue I wanted to eliminate the possibility that our SDK is somehow processing these incorrectly. Turns out it isn't. Can't hurt to add these tests to avoid regressions I think?