Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives 4096M to the Gradle and Kotlin daemons. #2121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JayShortway
Copy link
Member

Motivation

This is an attempt to fix the following error that's plaguing main:

Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

This is usually a lack of resources, in my experience.

We're using the Docker Large executor on CircleCI, which should have 8 GB of memory.

@JayShortway JayShortway requested review from facumenzella and a team February 6, 2025 15:58
@JayShortway JayShortway self-assigned this Feb 6, 2025
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ nice! I agree this is usually the reason for the issues, I think it's worth testing out how it works. Thanks for doing this!!

Copy link
Contributor

@facumenzella facumenzella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not All Heroes Wear Capes🦸

@JayShortway
Copy link
Member Author

I'm holding off with merging this one, for two combined reasons:

  1. CI failed with "Too long with no output (exceeded 10m0s): context deadline exceeded", which doesn't bode well.
  2. The other PR (Fixes "View field header collides with a variable" data binding error in PurchaseTester #2119) succeeded, and main also succeeded after merging that one.

If we keep hitting the disappearing daemon issue, I'll retry CI on this PR and merge it if successful.

@JayShortway JayShortway marked this pull request as draft February 7, 2025 11:33
@JayShortway
Copy link
Member Author

Okay it happened again on main. Let's see if CI wants to pass on this PR.

@JayShortway JayShortway marked this pull request as ready for review February 7, 2025 17:52
@JayShortway JayShortway enabled auto-merge (squash) February 7, 2025 17:52
@JayShortway JayShortway disabled auto-merge February 10, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants