-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing response fields to CustomerInfo
. Including transaction Prices
#2128
base: main
Are you sure you want to change the base?
Conversation
120a014
to
c9eec4e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
==========================================
- Coverage 80.87% 80.72% -0.16%
==========================================
Files 275 276 +1
Lines 9293 9347 +54
Branches 1296 1300 +4
==========================================
+ Hits 7516 7545 +29
- Misses 1233 1255 +22
- Partials 544 547 +3 ☔ View full report in Codecov by Sentry. |
/** | ||
* The display name of the subscription. | ||
*/ | ||
val displayName: String?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the one set in the dashboard right?
import java.util.Locale | ||
|
||
@Serializable | ||
internal class PriceResponse( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be a data class
instead?
This pull request introduces several enhancements and new features to the
SubscriptionInfo
and related classes in thepurchases
module. The most important changes include adding new properties to theSubscriptionInfo
class, creating a newPriceResponse
class, and updating theSubscriptionInfoResponse
class to include additional fields.Enhancements to
SubscriptionInfo
and related classes:purchases/src/main/kotlin/com/revenuecat/purchases/SubscriptionInfo.kt
:autoResumeDate
,displayName
,price
, andproductPlanIdentifier
to theSubscriptionInfo
class. [1] [2]locale
parameter to the constructor ofSubscriptionInfo
, for building the pricepurchases/src/main/kotlin/com/revenuecat/purchases/common/responses/PriceResponse.kt
:PriceResponse
class to handle price-related information.purchases/src/main/kotlin/com/revenuecat/purchases/common/responses/SubscriptionInfoResponse.kt
:SubscriptionInfoResponse
class to includeautoResumeDate
,displayName
,price
, andproductPlanIdentifier
fields. [1] [2]purchases/src/main/kotlin/com/revenuecat/purchases/models/Transaction.kt
:displayName
,isSandbox
,originalPurchaseDate
, andprice
to theTransaction
class. [1] [2]Additional updates:
purchases/src/main/kotlin/com/revenuecat/purchases/utils/PriceExtensions.kt
:MICRO_MULTIPLIER
tointernal
.