Crash on Amazon paywalls after purchasing #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
vegaro
commented
Apr 25, 2024
lib/models/store_transaction.dart
Outdated
| @Deprecated('Use orderId instead.') | ||
| /// RevenueCat Id associated to the transaction. | ||
| @Default('') String transactionIdentifier, | ||
| } |
There was a problem hiding this comment.
This needs to be made optional in order to have a default, which it actually makes it a breaking change
vegaro
force-pushed
the
sdk-3430-crash-after-amazon-purchase-in-flutter
branch
from
1839bd1 to
ec6b4f3
Compare
vegaro
changed the title
vegaro
force-pushed
the
sdk-3430-crash-after-amazon-purchase-in-flutter
branch
from
fe066d9 to
aed64da
Compare
tonidero
approved these changes
Apr 29, 2024
This was referenced Apr 30, 2024
vegaro
added a commit
that referenced
this pull request
Apr 30, 2024
**This is an automatic release.** ### Bugfixes * Crash on Amazon paywalls after purchasing (#1053) via Cesar de la Vega (@vegaro) ### Dependency Updates * BillingClient has been updated to version 6.2.1 * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.6.1 (#1059) via RevenueCat Git Bot (@RCGitBot) * [Android 7.10.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.1) * [Android 7.10.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.0) * [iOS 4.41.2](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.2) * [iOS 4.41.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.1) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.6.0 (#1056) via RevenueCat Git Bot (@RCGitBot) * [Android 7.10.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.1) * [Android 7.10.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.0) * [iOS 4.41.2](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.2) * [iOS 4.41.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.1) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.5.1 (#1054) via RevenueCat Git Bot (@RCGitBot) * [Android 7.10.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.1) * [Android 7.10.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.0) * [iOS 4.41.2](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.2) * [iOS 4.41.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.1) ### Other Changes * Add `trigger_bump` lane (#1058) via Cesar de la Vega (@vegaro) --------- Co-authored-by: Cesar de la Vega <[email protected]>
Jethro87
pushed a commit
to Jethro87/purchases-flutter
that referenced
this pull request
Jan 4, 2025
In `PurchaseCompleted` we are passing a Flutter's `StoreTransaction` in the callback. This is very confusing but: - In Android `StoreTransaction` is what's returned after a successful purchase. This class has a nullable `orderId` - In Android `Transaction` is the transactions in the CustomerInfo. This class has a non-nullable `transactionIdentifier` The issue we are having is that in Flutter we only have one `StoreTransaction` with a non-nullable `transactionId`, and we are using it in both places, the `PurchaseCompleted` and `CustomerInfo`. I see several ways of fixing this: - Making transactionIdentifier nullable. I don’t like this. It’s breaking - Making transactionIdentifier an empty string. Fixing it in next major - Making transactionIdentifier an empty string, deprecating it and creating orderId which is nullable and the same as transactionIdentifier. We’ll have nullable orderIds in the customer info transactions where this object is also used. In Android we have two classes, one for CustomerInfo transactions (Transaction with non-nullable transactionId ) and StoreTransaction which is used for completed purchases - Making a copy of StoreTransaction and name it CompletedPurchase , but with a nullable transactionIdentifier. Also breaking since we need to modify the PurchaseCompleted callback to receive this object. Making a new callback won’t work because the broken `PurchaseCompleted will keep crashing. In this PR I am doing number 2, since it's the least breaking. This only affects apps using Amazon paywalls, which is not many. Will fix RevenueCat#1049
Jethro87
pushed a commit
to Jethro87/purchases-flutter
that referenced
this pull request
Jan 4, 2025
**This is an automatic release.** ### Bugfixes * Crash on Amazon paywalls after purchasing (RevenueCat#1053) via Cesar de la Vega (@vegaro) ### Dependency Updates * BillingClient has been updated to version 6.2.1 * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.6.1 (RevenueCat#1059) via RevenueCat Git Bot (@RCGitBot) * [Android 7.10.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.1) * [Android 7.10.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.0) * [iOS 4.41.2](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.2) * [iOS 4.41.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.1) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.6.0 (RevenueCat#1056) via RevenueCat Git Bot (@RCGitBot) * [Android 7.10.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.1) * [Android 7.10.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.0) * [iOS 4.41.2](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.2) * [iOS 4.41.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.1) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.5.1 (RevenueCat#1054) via RevenueCat Git Bot (@RCGitBot) * [Android 7.10.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.1) * [Android 7.10.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.10.0) * [iOS 4.41.2](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.2) * [iOS 4.41.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.41.1) ### Other Changes * Add `trigger_bump` lane (RevenueCat#1058) via Cesar de la Vega (@vegaro) --------- Co-authored-by: Cesar de la Vega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
PurchaseCompletedwe are passing a Flutter'sStoreTransactionin the callback. This is very confusing but:StoreTransactionis what's returned after a successful purchase. This class has a nullableorderIdTransactionis the transactions in the CustomerInfo. This class has a non-nullabletransactionIdentifierThe issue we are having is that in Flutter we only have one
StoreTransactionwith a non-nullabletransactionId, and we are using it in both places, thePurchaseCompletedandCustomerInfo.I see several ways of fixing this:
In this PR I am doing number 2, since it's the least breaking. This only affects apps using Amazon paywalls, which is not many.
Will fix #1049