Remove SafeArea in sample in paywall.dart #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
tonidero
approved these changes
May 6, 2024
tonidero
added a commit
that referenced
this pull request
May 16, 2024
**This is an automatic release.** ### Bugfixes * [EXTERNAL] fix: call presentPaywallIfNeeded when needed (#1066) by @danjocha (#1069) via Cesar de la Vega (@vegaro) ### Dependency Updates * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.6.2 (#1067) via RevenueCat Git Bot (@RCGitBot) ### Other Changes * Remove SafeArea in sample in paywall.dart (#1063) via Cesar de la Vega (@vegaro) * Migration to applying Gradle plugins with the declarative plugins block in sample (#1062) via Cesar de la Vega (@vegaro) --------- Co-authored-by: Toni Rico <[email protected]>
Jethro87
pushed a commit
to Jethro87/purchases-flutter
that referenced
this pull request
Jan 4, 2025
The `SafeArea` was causing the X close button to be pushed down <img width="246" alt="Screenshot 2024-04-26 at 11 05 55" src="https://github.com/RevenueCat/purchases-flutter/assets/664544/da8712cc-3828-420a-925e-bd000f355851"> It looks like the `SafeArea` is adding some padding causing the `StatusBarSpacer` in purchases-android to add the wrong Spacer ``` @composable fun StatusBarSpacer() { return Spacer( Modifier.windowInsetsTopHeight( WindowInsets.statusBars, ), ) } ``` It doesn't make sense we wrap the `PaywallView` in a `SafeArea` since it should fill up the Activity that contains it so I removed it from the purchase tester to represent a more realistic scenario.
Jethro87
pushed a commit
to Jethro87/purchases-flutter
that referenced
this pull request
Jan 4, 2025
**This is an automatic release.** ### Bugfixes * [EXTERNAL] fix: call presentPaywallIfNeeded when needed (RevenueCat#1066) by @danjocha (RevenueCat#1069) via Cesar de la Vega (@vegaro) ### Dependency Updates * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.6.2 (RevenueCat#1067) via RevenueCat Git Bot (@RCGitBot) ### Other Changes * Remove SafeArea in sample in paywall.dart (RevenueCat#1063) via Cesar de la Vega (@vegaro) * Migration to applying Gradle plugins with the declarative plugins block in sample (RevenueCat#1062) via Cesar de la Vega (@vegaro) --------- Co-authored-by: Toni Rico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SafeAreawas causing the X close button to be pushed downIt looks like the
SafeAreais adding some padding causing theStatusBarSpacerin purchases-android to add the wrong SpacerIt doesn't make sense we wrap the
PaywallViewin aSafeAreasince it should fill up the Activity that contains it so I removed it from the purchase tester to represent a more realistic scenario.