Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prepaid periodType #1277

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Add prepaid periodType #1277

merged 2 commits into from
Feb 24, 2025

Conversation

fire-at-will
Copy link
Contributor

Adds the prepaid PeriodType case, along with the API tests and a parsing test

@fire-at-will fire-at-will added bug Something isn't working pr:fix A bug fix labels Feb 24, 2025
@fire-at-will fire-at-will requested review from a team and greenietea February 24, 2025 17:38
@fire-at-will fire-at-will marked this pull request as ready for review February 24, 2025 17:38
JayShortway
JayShortway approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@JayShortway JayShortway left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just the missing API test. (I'm blind. I did see that file, but didn't register that it was an API test, and then went and looked for API tests to see if we even have them. 🤦)

@fire-at-will fire-at-will merged commit 829b558 into main Feb 24, 2025
8 checks passed
@fire-at-will fire-at-will deleted the add-prepaid-period-type branch February 24, 2025 17:55
@RCGitBot RCGitBot mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayShortway JayShortway JayShortway approved these changes

@greenietea greenietea Awaiting requested review from greenietea

Assignees
No one assigned
Labels
bug Something isn't working pr:fix A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fire-at-will @JayShortway