Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.4.5 #240

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Release 3.4.5 #240

merged 3 commits into from
Sep 7, 2021

Conversation

beylmk
Copy link
Contributor

@beylmk beylmk commented Sep 7, 2021

The actual release...

@beylmk beylmk requested a review from vegaro September 7, 2021 17:35
Copy link
Member

@aboedo aboedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but let's update the previous changelogs so when we look back at these they're clear

CHANGELOG.md Outdated
- Bumped purchases-android to 4.3.1 [Changelog here](https://github.com/RevenueCat/purchases-android/releases/4.3.1),
which fixes canMakePayments not returning (see related issue: https://github.com/RevenueCat/purchases-unity/issues/61)
- Bumped purchases-hybrid-common to 1.9.1 [Changelog here](https://github.com/RevenueCat/purchases-hybrid-common/releases/tag/1.9.1)

## 3.4.4

- Bumped purchases-android to 4.3.1 [Changelog here](https://github.com/RevenueCat/purchases-android/releases/4.3.1),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update this line, since it's not really representative of what happened before (and maybe update the release in GH as well)

VERSIONS.md Outdated
@@ -1,5 +1,6 @@
| Version | iOS version | Android version | Common files version |
|---------|-------------|-----------------|----------------------|
| 3.4.5 | 3.12.3 | 4.3.1 | 1.9.1 |
| 3.4.4 | 3.12.3 | 4.3.1 | 1.9.1 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aboedo updated!

@beylmk beylmk merged commit d144e6e into main Sep 7, 2021
@beylmk beylmk deleted the release/3.4.5 branch September 7, 2021 23:22
Jethro87 pushed a commit to Jethro87/purchases-flutter that referenced this pull request Jan 4, 2025
* Prep for release

* Update VERSIONS.md and changelog to reflect buggy release

* Update hybrid common dependency for sample apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants