-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.4.5 #240
Release 3.4.5 #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but let's update the previous changelogs so when we look back at these they're clear
CHANGELOG.md
Outdated
- Bumped purchases-android to 4.3.1 [Changelog here](https://github.com/RevenueCat/purchases-android/releases/4.3.1), | ||
which fixes canMakePayments not returning (see related issue: https://github.com/RevenueCat/purchases-unity/issues/61) | ||
- Bumped purchases-hybrid-common to 1.9.1 [Changelog here](https://github.com/RevenueCat/purchases-hybrid-common/releases/tag/1.9.1) | ||
|
||
## 3.4.4 | ||
|
||
- Bumped purchases-android to 4.3.1 [Changelog here](https://github.com/RevenueCat/purchases-android/releases/4.3.1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should update this line, since it's not really representative of what happened before (and maybe update the release in GH as well)
VERSIONS.md
Outdated
@@ -1,5 +1,6 @@ | |||
| Version | iOS version | Android version | Common files version | | |||
|---------|-------------|-----------------|----------------------| | |||
| 3.4.5 | 3.12.3 | 4.3.1 | 1.9.1 | | |||
| 3.4.4 | 3.12.3 | 4.3.1 | 1.9.1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aboedo updated!
* Prep for release * Update VERSIONS.md and changelog to reflect buggy release * Update hybrid common dependency for sample apps
The actual release...
which fixes canMakePayments not returning (see related issue: productIdentifier null or empty in Purchases.PurchasePackage callback purchases-unity#61)