Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing error codes #64

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Add missing error codes #64

merged 1 commit into from
Jun 16, 2020

Conversation

korzonkiee
Copy link
Contributor

This PR adds error codes that were introduced in native sdks, but missed in Dart port:

  • invalidAppleSubscriptionKeyError,
  • ineligibleError,
  • invalidSubscriberAttributesError

Those missed error codes caused

RangeError (length): Invalid value: Not in range 0..18, inclusive: 20

in https://github.com/RevenueCat/purchases-flutter/blob/develop/lib/errors.dart#L27 when native sdk reported error code greater than 18.

aboedo
aboedo approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@aboedo aboedo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for opening!! @korzonkiee

@aboedo aboedo merged commit f1be3b6 into RevenueCat:develop Jun 16, 2020
@aboedo aboedo mentioned this pull request Jun 16, 2020
Closed
@vegaro vegaro mentioned this pull request Jun 26, 2020
Merged
Jethro87 pushed a commit to Jethro87/purchases-flutter that referenced this pull request Jan 4, 2025
@korzonkiee
Add missing error codes (RevenueCat#64)
a0f5ac1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboedo aboedo aboedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korzonkiee @aboedo