Use includeBuilds for better local development #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aboedo
reviewed
Jun 16, 2020
example/android/settings.gradle
Outdated
|
|
||
| // Run enableLocalBuild task to enable building purchases-hybrid-common from your local copy | ||
| if (file(".composite-enable").exists()) { | ||
| includeBuild ('../../../../purchases-hybrid-common/android') |
There was a problem hiding this comment.
is this line assuming the local path of purchases-hybrid-common?
There was a problem hiding this comment.
yes, what could we do to make this easier? maybe an environment variable?
There was a problem hiding this comment.
env variable would be the absolute ideal
|
@aboedo I changed so the task now accepts a parameter with the path:
|
aboedo
approved these changes
Jun 16, 2020
|
awesome!! |
2 tasks
Jethro87
pushed a commit
to Jethro87/purchases-flutter
that referenced
this pull request
Jan 4, 2025
* creates task to enable local builds * upgrades versions * removes purchases dependency * adds parameter to specify path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://proandroiddev.com/saying-goodbye-to-snapshots-with-gradles-composite-builds-bc98751392f6 and https://galex.co.il/2017/09/12/The_Best_of_Two_worlds_with_Gradle_Composite_Builds.html.
This adds two new gradle tasks
enableLocalBuildanddisableLocalBuild. By runningenableLocalBuildgradle will use the local copy ofpurchases-hybrid-commoninstead of the one dowloaded from maven.Depends on github.com/RevenueCat/purchases-hybrid-common/pull/44