PurchaseTester: setting changelog when submitting to TestFlight
#2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
commented
Jan 18, 2023
| @@ -659,5 +652,5 @@ lane :check_pods do | |||
| end | |||
|
|
|||
| def current_version_number | |||
| File.read("../.version").strip | |||
| File.read("#{File.dirname(__FILE__)}/../.version").strip | |||
There was a problem hiding this comment.
This was slightly wrong, now it works when called from any folder.
There was a problem hiding this comment.
yeah, my bad, I didn't really consider paths other than calling from root. Solid improvement
There was a problem hiding this comment.
It wasn't used from any of the testers before :)
NachoSoto
force-pushed
the
purchase-tester-testflight-changelog
branch
2 times, most recently
from
93c4d3e to
7d35471
Compare
This will provide some context when a new build is submitted. Also changed the lane to use `upload_to_testflight` instead of `upload_to_appstore`.
aboedo
approved these changes
Jan 18, 2023
.circleci/config.yml
Outdated
| @@ -720,42 +720,8 @@ workflows: | |||
| not: | |||
| equal: [ scheduled_pipeline, << pipeline.trigger_source >> ] | |||
| jobs: | |||
| - lint: | |||
There was a problem hiding this comment.
all of these are coming back before merging, right?
There was a problem hiding this comment.
Removed commit 👍🏻 was making sure it was still working.
| @@ -659,5 +652,5 @@ lane :check_pods do | |||
| end | |||
|
|
|||
| def current_version_number | |||
| File.read("../.version").strip | |||
| File.read("#{File.dirname(__FILE__)}/../.version").strip | |||
There was a problem hiding this comment.
yeah, my bad, I didn't really consider paths other than calling from root. Solid improvement
NachoSoto
force-pushed
the
purchase-tester-testflight-changelog
branch
from
7d35471 to
2474812
Compare
NachoSoto
added a commit
that referenced
this pull request
Jan 18, 2023
…ght` changelog Follow up to #2232.
NachoSoto
pushed a commit
that referenced
this pull request
Jan 19, 2023
**This is an automatic release.** ### Bugfixes * `Purchases`: avoid potential crash when initializing in the background (#2231) via NachoSoto (@NachoSoto) ### Other Changes * `PurchaseTester`: ignore errors when restoring purchases (#2228) via NachoSoto (@NachoSoto) * `PurchaseTester`: fixed `isPurchasing` state when purchasing fails (#2229) via NachoSoto (@NachoSoto) * `PurchaseTester`: setting `changelog` when submitting to `TestFlight` (#2232) via NachoSoto (@NachoSoto) * Revert "`SPM`: added `APPLICATION_EXTENSION_API_ONLY` flag to `RevenueCat` and `ReceiptParser` (#2217)" (#2225) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will provide some context when a new build is submitted.
Also changed the lane to use
upload_to_testflightinstead ofupload_to_appstore.