Paywalls: new optional displayCloseButton parameter
#3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
approved these changes
Oct 30, 2023
RevenueCatUI/PaywallView.swift
Outdated
| Button { | ||
| self.dismiss() | ||
| } label: { | ||
| Image(systemName: "xmark") |
There was a problem hiding this comment.
In Android I used our own close button vector image for this, but I think it should be ok (probably preferrable) to use the system one.
There was a problem hiding this comment.
Yeah this uses SFSymbols which is definitely preferred.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3359 +/- ##
==========================================
+ Coverage 85.96% 85.99% +0.02%
==========================================
Files 237 237
Lines 17132 17132
==========================================
+ Hits 14728 14733 +5
+ Misses 2404 2399 -5 ☔ View full report in Codecov by Sentry. |
NachoSoto
force-pushed
the
paywalls-close-button
branch
2 times, most recently
from
12bca43 to
d664465
Compare
NachoSoto
force-pushed
the
paywalls-close-button
branch
from
d664465 to
f94d530
Compare
NachoSoto
added a commit
that referenced
this pull request
Oct 31, 2023
When presenting `PaywallView` inside of a `NavigationView` (which was automatic, and more common with #3359) the icon had too much padding at the top:  e With this fix (note there is no actual navigation title): 
This was referenced Nov 1, 2023
NachoSoto
added a commit
that referenced
this pull request
Nov 2, 2023
**This is an automatic release.** ### New Features * `Offering`: new `getMetadataValue` with `Decodable` type (#3373) via NachoSoto (@NachoSoto) * Add `StoreProduct.pricePerWeek` (#3354) via NachoSoto (@NachoSoto) ### RevenueCatUI * `Paywalls`: `.presentPaywallIfNeeded` allows overriding `Offering` (#3370) via NachoSoto (@NachoSoto) * `Paywalls`: new optional `displayCloseButton` parameter (#3359) via NachoSoto (@NachoSoto) * `Paywalls`: improve period abbreviations in Japanese (#3367) via NachoSoto (@NachoSoto) * `Paywalls`: new `{{ sub_price_per_week }}` variable (#3355) via NachoSoto (@NachoSoto) * `Paywalls`: log warning when attempting to purchase already-subscribed product (#3366) via NachoSoto (@NachoSoto) * `Paywalls`: improve Japanese localization (#3364) via NachoSoto (@NachoSoto) * `Paywalls`: fix template 2 top padding inside navigation view (#3363) via NachoSoto (@NachoSoto) * `Paywalls`: avoid animating `PurchaseButton` labels when text does not change (#3361) via NachoSoto (@NachoSoto) * `Paywalls`: improve `FooterView` accessibility (#3349) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump cocoapods from 1.14.0 to 1.14.2 (#3356) via dependabot[bot] (@dependabot[bot]) * Bump cocoapods from 1.13.0 to 1.14.0 (#3351) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `Paywalls`: simplify `PurchaseButton` (#3362) via NachoSoto (@NachoSoto) * `Paywalls`: refactored `IntroEligibilityStateView` (#3360) via NachoSoto (@NachoSoto) * `Paywall Tester`: improve template 5 dark colors (#3358) via NachoSoto (@NachoSoto) * `Paywalls`: improve conversion from `Color`/`UIColor` to `PaywallColor` (#3357) via NachoSoto (@NachoSoto) * `Paywalls Tester`: improve `.paywallFooter` presentation (#3348) via NachoSoto (@NachoSoto) * `Paywalls`: move size configuration to `TemplateViewType` (#3352) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <[email protected]>
NachoSoto
added a commit
that referenced
this pull request
Nov 7, 2023
See #3359. This brings support for that parameter to the `UIKit` type.
NachoSoto
added a commit
that referenced
this pull request
Nov 7, 2023
See #3359. This brings support for that parameter to the `UIKit` type.
NachoSoto
added a commit
that referenced
this pull request
Nov 8, 2023
See #3359. This brings support for that parameter to the `UIKit` type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation points out that this is only automatic when using
presentPaywallIfNeeded, but it can also be useful to haveRevenueCatUIdo this automatically.