RevenueCatUI: added support to other deployment targets
#3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to #3378. This allows us to link both `RevenueCat` and `RevenueCatUI` from `PurchasesHybridCommon` supporting the same platforms. The actual types might not be available in some platforms / versions, but we can detect that at compile time.
NachoSoto
commented
Nov 7, 2023
| @@ -960,7 +960,7 @@ lane :check_pods do | |||
| verbose: true, | |||
| podspec: 'RevenueCatUI.podspec', | |||
| include_podspecs: 'RevenueCat.podspec', | |||
| platforms: 'ios', | |||
| platforms: 'ios,osx,tvos,watchos', | |||
There was a problem hiding this comment.
This will be linted now
NachoSoto
force-pushed
the
revenuecatui-macos-podspec
branch
from
192ea05 to
a0a2057
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3392 +/- ##
==========================================
- Coverage 86.04% 86.03% -0.01%
==========================================
Files 237 237
Lines 17187 17187
==========================================
- Hits 14788 14787 -1
- Misses 2399 2400 +1 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Nov 8, 2023
aboedo
approved these changes
Nov 8, 2023
Co-authored-by: Andy Boedo <[email protected]>
This was referenced Nov 8, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Nov 8, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: add `displayCloseButton` to `PaywallViewController` (#3391) via NachoSoto (@NachoSoto) * `Paywalls`: fix Turkish translation (#3389) via Dogancan Mavideniz (@mavideniz) * `Paywalls`: fix Turkish translation (#3388) via iremkaraoglu (@iremkaraoglu) ### Other Changes * `RevenueCatUI`: added support to other deployment targets (#3392) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3378.
This allows us to link both
RevenueCatandRevenueCatUIfromPurchasesHybridCommonsupporting the same platforms.The actual types might not be available in some platforms / versions, but we can detect that at compile time.
See https://app.circleci.com/pipelines/github/RevenueCat/purchases-hybrid-common/2564/workflows/ea6a4e24-e1eb-4c7a-a930-173945732999/jobs/10352