Paywalls: tests for PurchaseButton layout logic
#3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds test coverage for the logic added in #3361, now extracted from `PurchaseButton` into a `TemplateViewConfiguration` extension.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3468 +/- ##
=======================================
Coverage 86.07% 86.07%
=======================================
Files 237 237
Lines 17204 17204
=======================================
Hits 14809 14809
Misses 2395 2395 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Nov 22, 2023
joshdholtz
approved these changes
Nov 22, 2023
aboedo
approved these changes
Nov 22, 2023
Tests/RevenueCatUITests/Data/TemplateViewConfigurationTests.swift
Outdated
Show resolved
Hide resolved
This was referenced Nov 29, 2023
tonidero
pushed a commit
that referenced
this pull request
Dec 1, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: remove empty space when template 4 has no offer details (#3469) via NachoSoto (@NachoSoto) ### Other Changes * `Concurrency`: address strict concurrency issues on `SystemInfo` (#3462) via NachoSoto (@NachoSoto) * `CircleCI`: upgrade to Xcode 15.1 (#3403) via NachoSoto (@NachoSoto) * `Paywalls`: tests for `PurchaseButton` layout logic (#3468) via NachoSoto (@NachoSoto) * `Paywalls`: simplified `PaywallViewMode` logic (#3470) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test coverage for the logic added in #3361, now extracted from
PurchaseButtoninto aTemplateViewConfigurationextension.