Support Redeeming Win-Back Offers with Streamlined Purchasing Disabled #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-at-will
added
pr:feat
fire-at-will
commented
Oct 10, 2024
…ined_purchases_disabled
…ined_purchases_disabled
fire-at-will
changed the title
| /** | ||
| * Constructs an Error with the ``ErrorCode/invalidSubscriptionOffer`` code. | ||
| */ | ||
| static func invalidSubscriptionOfferError( |
There was a problem hiding this comment.
I'm probably missing something but I can't find where this error is used 🤔
There was a problem hiding this comment.
Ahh. This was used in the purchase(sk2Product:winbackOffer:) function that we removed earlier in the review process. Good catch! 😄
I've removed this in 08ebe4f. We might want to bring back something similar when implementing win-backs into the purchase params, but we can cross that bridge when we get there 😄
…ined_purchases_disabled
…ined_purchases_disabled
fire-at-will
changed the title
| // stop the compiler from checking availability in the functions. | ||
| // We also need to ensure that we're on Xcode >= 15.3, since that is when | ||
| // PurchaseIntents were first made available on macOS. | ||
| #if !os(tvOS) && !os(watchOS) && compiler(>=5.10) |
There was a problem hiding this comment.
Does it work if we add the availability to the function instead?
MarkVillacampa
approved these changes
Nov 6, 2024
…ined_purchases_disabled
|
@RCGitBot please test |
|
@RCGitBot please test |
|
@RCGitBot please test |
|
@RCGitBot please test |
…ined_purchases_disabled
|
@RCGitBot please test |
…ined_purchases_disabled
|
@RCGitBot please test |
fire-at-will
deleted the
CAT-1708_purchase_winback_offer_with_streamlined_purchases_disabled
branch
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for redeeming win-back offers with Streamlined Purchasing disabled.
Feature Availability
This feature is available for developers under the following conditions:
Implementation Details
Observing the SK1 Payment Queue
Apple has a note in their PurchaseIntent docs that reads:
Of course, we can't perform conditional compilation based on the OS since version since that isn't known at compile time. Instead, this PR modifies the
PaymentQueueWrapperclass used when the SDK is running in SK2 mode so that it only observes the SK1 payment queue when thePurchaseIntentsAPI is available (iOS >=16.4, macOS >=14.4, compiled on Xcode >=16.0).API Changes
There are no breaking API changes with this PR. When we receive a Purchase Intent with a win-back offer attached to it, we call the
PurchaseDelegate'sreadyForPromotedProduct()function, and when the developer is ready for the user to complete the win-back offer redemption flow, they call its completion handler.OS/Feature Availability
PurchaseIntents were introduced in iOS 16.4, so we need to be careful about whether we use PurchaseIntents or SK1, depending on the runtime environment. Here's a full matrix of what features/technologies are available on each OS version:
Testing