The StackComponent has an optional shadow #4429
Merged
+203
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayShortway
commented
Oct 31, 2024
Comment on lines
+60
to
+61
| // Without compositingGroup(), the shadow is applied to the stack's children as well. | ||
| view.compositingGroup().shadow(shadow: shadow) |
There was a problem hiding this comment.
The reason for not adding compositingGroup() directly to the new shadow() modifier is that I wanted the latter to behave the same as the built-in one to avoid confusion. Let me know if you disagree!
There was a problem hiding this comment.
TIL about compositingGroup() 😅
joshdholtz
approved these changes
Oct 31, 2024
Comment on lines
+60
to
+61
| // Without compositingGroup(), the shadow is applied to the stack's children as well. | ||
| view.compositingGroup().shadow(shadow: shadow) |
There was a problem hiding this comment.
TIL about compositingGroup() 😅
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. I was initially going to build this just for the sticky footer, but I noticed on Figma that any stack can have a shadow, hence this PR.
Applied to the sticky footer, it looks like this: