[Paywalls V2] Update stack size spec #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
changed the title
fire-at-will
approved these changes
Nov 11, 2024
Sources/Paywalls/Components/Common/PaywallComponentPropertyTypes.swift
Outdated
Show resolved
Hide resolved
Base automatically changed from
paywalls-v2/schema-rework-part-1-color
to
main
November 11, 2024 20:12
joshdholtz
force-pushed
the
paywalls-v2/schema-rework-part-2-size-stack
branch
from
582f6e3 to
8da48a3
Compare
|
@RCGitBot please test |
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update stack size per spec
Description
All basic components (text, image, and stacks) gained a size property. It allows their
widthandheightto be eitherfit,fill, orfixedThis is the implementation for
StackComponentandStackComponentViewwidthwithsize.size(Size)view modifier that applies these width and height settings and can be used by other componentsFlexVStack(similar toFlexHStack) which wasn't added before 🤷♂️Demo
Screen.Recording.2024-11-11.at.6.36.40.AM.mov