[Paywalls V2] Update color spec #4468
Conversation
joshdholtz
changed the title
There was a problem hiding this comment.
Looks good to me!
One question: Did you mean to remove Tests/TestingApps/PaywallsTester/PaywallsTester/Config/SamplePaywalls.swift and Tests/TestingApps/PaywallsTester/PaywallsTester/UI/Views/SamplePaywallsList.swift? I didn't see any mention of it in the PR description so I figured I'd double check
|
|
||
| } | ||
|
|
||
| // struct ColorInfo: Codable, Sendable, Hashable, Equatable { |
There was a problem hiding this comment.
Nit: remove commented code
There was a problem hiding this comment.
Ha! I did notice this and it gets removed like 2 PRs in 😛
| } | ||
| } | ||
|
|
||
| public init(from decoder: Decoder) throws { |
There was a problem hiding this comment.
I might think about adding in some tests to validate the custom encoding/decoding of the ColorInfo enum. I know from recent experience in Pines that it's easy to make mistakes in these custom enum codable implementations and it's easy to miss until much later in testing
There was a problem hiding this comment.
Yes yes, for sure! Tests coming soon™️
Motivation
Updating color property to hold more types info:
Note: Developers will soon™️ be able to define global colors for the project and paywall components will be able to reference them by name (alias)
ℹ️ This is A LOT of struct-ural changes to make this complie again but no functional changes were made
Description
Previously
Colors were strictly a hex color value
{ "light": "#ffffff", "dark": "#000000" }Now
Colors can be a type of
hexoralias(a name to a dictionary that will be coming down in the API response with all paywalls that is common on a project){ "light": { "type": "hex", "value": "#ffffff" }, "dark": { "type": "hex", "value": "#000000" } }or
{ "light": { "type": "alias", "value": "primary" }, "dark": { "type": "alias", "value": "primary_dark" } }