Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paywalls V2] Update shape spec #4472

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Nov 12, 2024

Motivation

Update to latest shape spec for stack and image

Description

  • Stack
    • Has rectangle (with corners) and pill
  • Image
    • Has rectangle (with corners) and pill, concave, and convex

Made a new .shape() view modifier that takes:

  • border
  • shape

⚠️ Not implementing concave and convex yet

Stack Image
Simulator Screenshot - iPhone 16 Pro - 2024-11-11 at 14 02 55 Simulator Screenshot - iPhone 16 Pro - 2024-11-11 at 20 52 25

@joshdholtz joshdholtz marked this pull request as ready for review November 12, 2024 03:50
@joshdholtz joshdholtz requested review from a team November 12, 2024 03:50
@joshdholtz joshdholtz merged commit 5b85814 into main Nov 13, 2024
7 checks passed
@joshdholtz joshdholtz deleted the paywalls-v2/schema-rework-part-4-stack-shape branch November 13, 2024 12:06
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants